Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] product_harmonized_system #266

Closed
wants to merge 35 commits into from
Closed

[17.0][MIG] product_harmonized_system #266

wants to merge 35 commits into from

Conversation

AndreuOForgeFlow
Copy link

Standard migration

@ForgeFlow

BenjaHe and others added 30 commits March 11, 2024 15:33
@AndreuOForgeFlow
[13.0] [MIG] product harmonized system (OCA#80)
db53aac 
* Large code re-engineering following the Akretion-Noviat code sprint on intrastat

This code has been written both by Luc de Meyer and myself.

* hs_code display_name fix

* major update intrastat V3 modules

* Add product_origin_country_id on declaration/computation lines

Copy incoterms and destination country from SO to invoice when invoicing from SO
We need weight even when supplementary units is used
Small cleanups and enhancements

* Add support for accessory costs

Add default values for intrastat transaction on company
Code cleanup

* this week's ci errors

* Update README.rst

Rename variables

* Port intrastat_base to v10

Set 2 other modules to uninstallable
Update README.rst: switch to new intrastat project

* Port product_harmonized_system to v10

* Fix warning on display_name

Special thanks to Pedro and Holger for finding the solution for display_name
Fix demo data

* [MIG] product_harmonized_system: Migration to 11.0

* [FIX] product_harmonized_system: fix get_hs_code_recurively

* [IMP] *: removed utf-8 headers, changed icon and site

* company model test, country model test as in v8
* png logo instead of svg, removed Python 2 utf-8 headers

* [UPD] Update product_harmonized_system.pot

* Add new module product_harmonized_system_delivery (hide native hs_code field)

Finalize port to v11

* [FIX+IMP] intrastat_*: Several things:

* Add readonly on some fields when state of declaration is done
* Division by zero in computation of accessory costs
* Add FR translation
* Fix strings
* Minor code updates

* [MIG] intrastat_product: Migration to 11.0

* Small fixes in intrastat_base
* account_tax_template

* [ADD] icon.png

* [UPD] Update product_harmonized_system.pot

* Prepare v12 branch

* [MIG] Migrate all modules from v11 to v12

* flake8

* [UPD] Update product_harmonized_system.pot

* Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: intrastat-extrastat-12.0/intrastat-extrastat-12.0-product_harmonized_system
Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-12-0/intrastat-extrastat-12-0-product_harmonized_system/

* [FIX] product_harmized_system DESCRIPTION.rst

* [UPD] README.rst

* [UPD] README.rst

* Added translation using Weblate (Spanish)

* Translated using Weblate (Spanish)

Currently translated at 50.0% (18 of 36 strings)

Translation: intrastat-extrastat-12.0/intrastat-extrastat-12.0-product_harmonized_system
Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-12-0/intrastat-extrastat-12-0-product_harmonized_system/es/

* [MIG] product_harmonized_system : Migration to 13.0

* [IMP] product_harmonized_system: black, isort

[UPD] README.rst

[UPD] Update product_harmonized_system.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: intrastat-extrastat-13.0/intrastat-extrastat-13.0-product_harmonized_system
Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-13-0/intrastat-extrastat-13-0-product_harmonized_system/
@luc-demeyer @AndreuOForgeFlow
[13.0][FIX]replace deprecated _company_default_get
8c31c32 
product_harmonized_system 13.0.1.0.1

pre-commit update
@alexis-via @AndreuOForgeFlow
intrastat_product: Add xml_attachment_id field
7641501 
intrastat_product: add mail.activity.mixin and widget in form view
product_harmonized_system: remove archive button (use Action menu)
All modules:
- use super() instead of super(class, self)
- Update domain_force in multi-company ir.rule to v13 standard
@alexis-via @AndreuOForgeFlow
[MIG] product_harmonized_system to v14
2555116 
[UPD] README.rst

[UPD] Update product_harmonized_system.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: intrastat-extrastat-14.0/intrastat-extrastat-14.0-product_harmonized_system
Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-14-0/intrastat-extrastat-14-0-product_harmonized_system/
@Mat-moran @AndreuOForgeFlow
Translated using Weblate (Spanish)
5b79aae 
Currently translated at 80.5% (29 of 36 strings)

Translation: intrastat-extrastat-14.0/intrastat-extrastat-14.0-product_harmonized_system
Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-14-0/intrastat-extrastat-14-0-product_harmonized_system/es/
@AndreuOForgeFlow
Translated using Weblate (French)
ec9496b 
Currently translated at 100.0% (36 of 36 strings)

Translation: intrastat-extrastat-14.0/intrastat-extrastat-14.0-product_harmonized_system
Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-14-0/intrastat-extrastat-14-0-product_harmonized_system/fr/
@AdriaGForgeFlow @AndreuOForgeFlow
[13.0] product_harmonized_system: do not require company on hs_code m…
a1992ab 
…odel

product_harmonized_system 14.0.1.0.1
@alexis-via @AndreuOForgeFlow
[MIG] hs_code_id company_dependent=True to False
260c8a4 
Migration script provided for product.template and product.category
Fixes bug OCA#126
@alexis-via @AndreuOForgeFlow
product_harmonized_system_delivery: hs_code is now store=True
05639fa 
This commit is the "followup" of the change to company_dependent=False
on the fields hs_code_id on product.template and product.category.
Add groupby on hs_code_id on product.template search view
hs.code is now company_id=False by default

[UPD] Update product_harmonized_system.pot

product_harmonized_system 14.0.2.1.0

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: intrastat-extrastat-14.0/intrastat-extrastat-14.0-product_harmonized_system
Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-14-0/intrastat-extrastat-14-0-product_harmonized_system/
@luc-demeyer @AndreuOForgeFlow
[14.0]Intrastat Brexit support
c405a31
@luc-demeyer @AndreuOForgeFlow
[14.0]intrastat - improved brexit support
b700a83 
[UPD] Update product_harmonized_system.pot

product_harmonized_system 14.0.2.2.0

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: intrastat-extrastat-14.0/intrastat-extrastat-14.0-product_harmonized_system
Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-14-0/intrastat-extrastat-14-0-product_harmonized_system/
@yweng8111 @AndreuOForgeFlow
[IMP] add tag 'sheet' into form view of hs.code
ffb4f53 
product_harmonized_system 14.0.2.3.0
@badbole @AndreuOForgeFlow
Added translation using Weblate (Croatian)
c954fbb
@badbole @AndreuOForgeFlow
Translated using Weblate (Croatian)
0b1ebcb 
Currently translated at 10.5% (4 of 38 strings)

Translation: intrastat-extrastat-14.0/intrastat-extrastat-14.0-product_harmonized_system
Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-14-0/intrastat-extrastat-14-0-product_harmonized_system/hr/
@alexis-via @AndreuOForgeFlow
[MIG] product_harmonized_system to v15
791a811 
TT36971
@AndreuOForgeFlow
[UPD] Update product_harmonized_system.pot
982f82b
@OCA-git-bot @AndreuOForgeFlow
[UPD] README.rst
e7d68bd
@alexis-via @AndreuOForgeFlow
[MIG] product_harmonized_system to v16
aa5f079
@AndreuOForgeFlow
[UPD] Update product_harmonized_system.pot
df5899d
@OCA-git-bot @AndreuOForgeFlow
[UPD] README.rst
15188fe
@weblate @AndreuOForgeFlow
Update translation files
7a059ef 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: intrastat-extrastat-16.0/intrastat-extrastat-16.0-product_harmonized_system
Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-16-0/intrastat-extrastat-16-0-product_harmonized_system/
@badbole @AndreuOForgeFlow
Translated using Weblate (Croatian)
6f69097 
Currently translated at 100.0% (35 of 35 strings)

Translation: intrastat-extrastat-16.0/intrastat-extrastat-16.0-product_harmonized_system
Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-16-0/intrastat-extrastat-16-0-product_harmonized_system/hr/
@Gelo-fl @AndreuOForgeFlow
Translated using Weblate (Spanish)
cf97d23 
Currently translated at 100.0% (35 of 35 strings)

Translation: intrastat-extrastat-16.0/intrastat-extrastat-16.0-product_harmonized_system
Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-16-0/intrastat-extrastat-16-0-product_harmonized_system/es/
@sanrav @AndreuOForgeFlow
Translated using Weblate (French)
bf3b9e0 
Currently translated at 100.0% (35 of 35 strings)

Translation: intrastat-extrastat-16.0/intrastat-extrastat-16.0-product_harmonized_system
Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-16-0/intrastat-extrastat-16-0-product_harmonized_system/fr/
@AndreuOForgeFlow
Translated using Weblate (French)
cc0bf92 
Currently translated at 100.0% (35 of 35 strings)

Translation: intrastat-extrastat-16.0/intrastat-extrastat-16.0-product_harmonized_system
Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-16-0/intrastat-extrastat-16-0-product_harmonized_system/fr/
@OCA-git-bot @AndreuOForgeFlow
[UPD] README.rst
e8decaa
@mymage @AndreuOForgeFlow
Added translation using Weblate (Italian)
cdb642e
@mymage @AndreuOForgeFlow
Translated using Weblate (Italian)
cbb2414 
Currently translated at 100.0% (35 of 35 strings)

Translation: intrastat-extrastat-16.0/intrastat-extrastat-16.0-product_harmonized_system
Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-16-0/intrastat-extrastat-16-0-product_harmonized_system/it/
@victoralmau @AndreuOForgeFlow
[FIX] product_harmonized_system: Change web_ribbon text to title to m…
8714fc4 
…ake it translatable
@AndreuOForgeFlow
[UPD] Update product_harmonized_system.pot
76ad964
mymage and others added 2 commits March 11, 2024 15:33
@mymage @AndreuOForgeFlow
Translated using Weblate (Italian)
515b6e5 
Currently translated at 100.0% (35 of 35 strings)

Translation: intrastat-extrastat-16.0/intrastat-extrastat-16.0-product_harmonized_system
Translate-URL: https://translation.odoo-community.org/projects/intrastat-extrastat-16-0/intrastat-extrastat-16-0-product_harmonized_system/it/
@AndreuOForgeFlow
[IMP] product_harmonized_system: pre-commit auto fixes
02ab466
GuillemCForgeFlow
GuillemCForgeFlow reviewed Mar 11, 2024
View reviewed changes
Copy link

@GuillemCForgeFlow GuillemCForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rest is fine, code review 👍🏽

product_harmonized_system/__manifest__.py Outdated Show resolved Hide resolved
product_harmonized_system/views/product_template.xml Show resolved Hide resolved
@pedrobaeza
Copy link
Member

/ocabot migration product_harmonized_system

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Mar 11, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 11, 2024
Open
6 tasks
@AndreuOForgeFlow AndreuOForgeFlow force-pushed the 17.0-mig-product_harmonized_system branch from b7f30ae to 3e6604e Compare March 12, 2024 07:46
GuillemCForgeFlow
GuillemCForgeFlow approved these changes Mar 12, 2024
View reviewed changes
Copy link

@GuillemCForgeFlow GuillemCForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Code and functional review 👍🏽

JasminSForgeFlow
JasminSForgeFlow approved these changes Mar 14, 2024
View reviewed changes
Copy link

@JasminSForgeFlow JasminSForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

@GuillemCForgeFlow
Copy link

@pedrobaeza perhaps this is ready to be merged? 😄
So we can start with the migration for the rest of the modules, such as product_harmonized_system_delivery, product_harmonized_system_delivery and hs_code_link.

pedrobaeza
pedrobaeza approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-266-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 14, 2024
@OCA-git-bot
Merge PR #266 into 17.0
de45535 
Signed-off-by pedrobaeza
@alexis-via
Copy link
Contributor

@GuillemCForgeFlow hs_code_link is a duplicate of product_harmonized_system_stock_delivery (rename of product_harmonized_system_delivery for v17). So please don't port hs_code_link !

@GuillemCForgeFlow
Copy link

@alexis-via you're right, thank you for the notice 👍🏽

@alexis-via
Copy link
Contributor

You can take inspiration from my v17 migration PR which was cancelled because it had the 3 modules (product_harmonized_system, product_harmonized_system_stock and product_harmonized_system_stock_delivery) in the same PR : here is the v17 migration commit 806c27b That's how I noticed that the update of ir.model.access was missing.

@GuillemCForgeFlow
Copy link

You can take inspiration from my v17 migration PR which was cancelled because it had the 3 modules (product_harmonized_system, product_harmonized_system_stock and product_harmonized_system_stock_delivery) in the same PR : here is the v17 migration commit 806c27b That's how I noticed that the update of ir.model.access was missing.

Great, that helps a lot! 😄 thank you for the heads up.

@AndreuOForgeFlow AndreuOForgeFlow force-pushed the 17.0-mig-product_harmonized_system branch from 3e6604e to e214519 Compare March 14, 2024 14:59
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0be01d0. Thanks a lot for contributing to OCA. ❤️

@GuillemCForgeFlow GuillemCForgeFlow deleted the 17.0-mig-product_harmonized_system branch March 14, 2024 15:09
@alexis-via
Copy link
Contributor

@GuillemCForgeFlow I thought you were aware of my previous v17 migration work on those modules... I should have mentionned it earlier, it would have saved you some work time!

@pedrobaeza
Copy link
Member

@AndreuOForgeFlow your last changes are not merged into the main branch, as you did the push after launching the command. If they are interesting, please do another IMP PR.

@AndreuOForgeFlow
Copy link
Author

@AndreuOForgeFlow your last changes are not merged into the main branch, as you did the push after launching the command. If they are interesting, please do another IMP PR.

Oh okay! Will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexis-via alexis-via alexis-via left review comments

@JasminSForgeFlow JasminSForgeFlow JasminSForgeFlow approved these changes

@GuillemCForgeFlow GuillemCForgeFlow GuillemCForgeFlow approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.