Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field hs_code_id on products and company_dependent #126

Closed
alexis-via opened this issue Mar 8, 2021 · 3 comments
Closed

Field hs_code_id on products and company_dependent #126

alexis-via opened this issue Mar 8, 2021 · 3 comments
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.

Comments

@alexis-via
Copy link
Contributor

Currently, in the module product_harmonized_system, the field hs_code_id on product.template and on product.category has company_dependent=True, cf
https://github.com/OCA/intrastat-extrastat/blob/14.0/product_harmonized_system/models/product_template.py#L16

Is it really a good idea ? Sometimes I think that it has been introduced by someone who needed it on a project in a very special context, but it adds extra complexity for everybody. In a standard scenario, HS code should not depend on company. HS code should be considered as "physical" property of a product, like the weight, which doesn't depend on the company.

What do you think ? Should be consider to switch back to company_dependent=False on v15 ?

@pedrobaeza
Copy link
Member

pedrobaeza commented Mar 8, 2021

Yes, I think the nature of the product shouldn't changed between companies. We can even consider it for v14, but doing a migration script for "materializing" the value correctly in new physical column. This migration script will be needed anyway when switching.

@azucenatrey
Copy link

Hello, we just detected the problem in 12.0 and we are going to make a modification to fix it.
When we have it, we will propose a PR to solve the issue.

alexis-via added a commit to akretion/intrastat-extrastat that referenced this issue Dec 13, 2021
Migration script provided for product.template and product.category
Fixes bug OCA#126
alexis-via added a commit to akretion/intrastat-extrastat that referenced this issue Dec 13, 2021
Migration script provided for product.template and product.category
Fixes bug OCA#126
alexis-via added a commit to akretion/intrastat-extrastat that referenced this issue Dec 13, 2021
Migration script provided for product.template and product.category
Fixes bug OCA#126
alexis-via added a commit to akretion/intrastat-extrastat that referenced this issue Dec 13, 2021
Migration script provided for product.template and product.category
Fixes bug OCA#126
alexis-via added a commit to akretion/intrastat-extrastat that referenced this issue Dec 16, 2021
Migration script provided for product.template and product.category
Fixes bug OCA#126
@github-actions
Copy link

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 10, 2022
victoralmau pushed a commit to Tecnativa/intrastat-extrastat that referenced this issue Aug 2, 2022
Migration script provided for product.template and product.category
Fixes bug OCA#126
alexis-via added a commit to akretion/intrastat-extrastat that referenced this issue Dec 27, 2022
Migration script provided for product.template and product.category
Fixes bug OCA#126
alexis-via added a commit to akretion/intrastat-extrastat that referenced this issue Dec 29, 2023
Migration script provided for product.template and product.category
Fixes bug OCA#126
nguyenminhchien pushed a commit to nguyenminhchien/intrastat-extrastat that referenced this issue Mar 11, 2024
Migration script provided for product.template and product.category
Fixes bug OCA#126
AndreuOForgeFlow pushed a commit to ForgeFlow/intrastat-extrastat that referenced this issue Mar 11, 2024
Migration script provided for product.template and product.category
Fixes bug OCA#126
LucasTran380381 pushed a commit to LucasTran380381/intrastat-extrastat that referenced this issue Nov 4, 2024
Migration script provided for product.template and product.category
Fixes bug OCA#126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

No branches or pull requests

3 participants