-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Field hs_code_id on products and company_dependent #126
Comments
Yes, I think the nature of the product shouldn't changed between companies. We can even consider it for v14, but doing a migration script for "materializing" the value correctly in new physical column. This migration script will be needed anyway when switching. |
Hello, we just detected the problem in 12.0 and we are going to make a modification to fix it. |
Migration script provided for product.template and product.category Fixes bug OCA#126
Migration script provided for product.template and product.category Fixes bug OCA#126
Migration script provided for product.template and product.category Fixes bug OCA#126
Migration script provided for product.template and product.category Fixes bug OCA#126
Migration script provided for product.template and product.category Fixes bug OCA#126
There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Migration script provided for product.template and product.category Fixes bug OCA#126
Migration script provided for product.template and product.category Fixes bug OCA#126
Migration script provided for product.template and product.category Fixes bug OCA#126
Migration script provided for product.template and product.category Fixes bug OCA#126
Migration script provided for product.template and product.category Fixes bug OCA#126
Migration script provided for product.template and product.category Fixes bug OCA#126
Currently, in the module product_harmonized_system, the field hs_code_id on product.template and on product.category has company_dependent=True, cf
https://github.com/OCA/intrastat-extrastat/blob/14.0/product_harmonized_system/models/product_template.py#L16
Is it really a good idea ? Sometimes I think that it has been introduced by someone who needed it on a project in a very special context, but it adds extra complexity for everybody. In a standard scenario, HS code should not depend on company. HS code should be considered as "physical" property of a product, like the weight, which doesn't depend on the company.
What do you think ? Should be consider to switch back to company_dependent=False on v15 ?
The text was updated successfully, but these errors were encountered: