[17.0][MIG] github_connector: Migration to 17.0 #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hod. [FIX] Add the organization_id.github_login to the github url Making the github url the form: https://github.com/OCA/account-analytic/tree/9.0 and not the https://github.com/account-analytic/tree/9.0 before this commit [IMP] Make travis happy [IMP] Fix error with teams sync We already have the organization in the team data, and github does not provide anymore in the result for the team data.
[IMP] raise error instead of logging in case of duplicates To avoid creating additional duplicates.
[FIX] add ondelete cascade [FIX] team creation from odoo [FIX] possibility to recursively load an existing object
[REF] github_connector: Fix typo "should not => does not" (OCA#6)
[FIX] github_connector: remove duplicated group
* Fixed JSON response parsing issue while fetching data by URL
* [IMP] Add try-except on branch analyze action Add try-except statements on analyze actions that could potentially crash the analyze process. * [REF] Fix error logging Changes include: - fix error values - use error instead of warning * [IMP] Fix error in analyze call Fix a programming mistake in the analyze call. By @RoelAdriaans * [IMP] Bump version number of github_connector Bump the version number of github_connector to '11.0.1.1.1'. * [IMP] Bump version number of github_connector Bump the version number of github_connector_odoo to '11.0.1.1.1'.
To play nice with Sentry.
[FIX] github_connector: keyerror 'blog' Description of the issue/feature this PR addresses: On new database error when syncing new github organization (example: OCA). Error traceback: KeyError: 'blog' Current behavior before PR: Synchronization gets blog key on `get_odoo_data_from_github` but blog field does not exist. When it tries to match the key with model attribute we get key error. Desired behavior after PR is merged: Get blog key from github data and show it on form view.
If source path does not exists before adding it to modules path, styles on website are corrupted, making impossible load them from assets.
Don't mix bytes and str
There's a mix between self and branch arguments in analyze methods.
…functional This field allows to define where addons are located, but it's hidden right now, because not everything is properly adjusted for paths different from root. Making this working, there's no need to hide the field.
linter Linter Linter default value to empty string in get()'s secure the code improvment of the code coding style coding style
Using os.command gets hung when there's a problem deleting the folder (for example, when no permissions), so this stucks the cron method or the manual process of updating source code. We avoid it using the Python utility for that through shutil. We also avoid an exception in that case enclosing the sentence in a try/except clause.
… error
{'github_create_date': datetime.datetime(2014, 9, 10, 13, 3, 33, tzinfo=tzlocal())}
ValueError: Datetime field expects a naive datetime: 2014-09-10 13:03:33+00:00
Necessary since PyGithub/PyGithub@0177f7c
Do not create lines if no file has been scanned
[UPD] Update github_connector.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: interface-github-16.0/interface-github-16.0-github_connector Translate-URL: https://translation.odoo-community.org/projects/interface-github-16-0/interface-github-16-0-github_connector/
Translated using Weblate (Italian) Currently translated at 100.0% (199 of 199 strings) Translation: interface-github-16.0/interface-github-16.0-github_connector Translate-URL: https://translation.odoo-community.org/projects/interface-github-16-0/interface-github-16-0-github_connector/it/
victoralmau
force-pushed
the
17.0-mig-github_connector
branch
2 times, most recently
from
278ce90 to
4d989c6
Compare
|
/ocabot migration github_connector |
pedrobaeza
approved these changes
Nov 8, 2024
victoralmau
force-pushed
the
17.0-mig-github_connector
branch
from
4d989c6 to
67fda30
Compare
carlos-lopez-tecnativa
approved these changes
Nov 8, 2024
victoralmau
force-pushed
the
17.0-mig-github_connector
branch
from
67fda30 to
9c7db57
Compare
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 329cd39. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration to 17.0
Please @pedrobaeza can you review it?
@Tecnativa TT51638