Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] github_connector_odoo: Migration to 17.0 #129

Merged
merged 44 commits into from
Nov 14, 2024

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Nov 8, 2024

Migration to 17.0

@Tecnativa TT51639

@pedrobaeza
Copy link
Member

You can rebase.

legalsylvain and others added 29 commits November 11, 2024 08:45
[FIX] module icon resize problem
* [FIX]  Fix field property

The property is 'readony'.

* [IMP]Get module icon from multiple sources

Get the module icon from the following sources (in order):
 1. From the first entry of the images tag from the manifest
 2. From the static directory
* [ADD] github_connector_odoo: New field category_id

[IMP] increase version number
[FIX] Lints

* [REF] removed unecessary variables.
[FIX] Lints

* [FIX] corrected version, since this update requires a module upgrade
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
Set a default icon per module, when no icon is defined in that
module. The default icon is the 'OCA cube', the icon is located
in the module itself (in /data/oca.png).
…CA#30)

* [FIX]do not delete module version if already exists and just update

* [FIX]remove not needed code

* [IMP] added clean odoo module version cron

* [IMP]support module_paths also

* [IMP]separate function fo the module path to remove redundant code
To play nice with Sentry.
There's a mix between self and branch arguments in analyze methods.
…functional

This field allows to define where addons are located, but it's hidden right now, because
not everything is properly adjusted for paths different from root.

Making this working, there's no need to hide the field.
Putting fields.Image doesn't add value, as this is only for auto-resizing. The
interesting thing is to add `attachment=True`, that allows to store the images
as attachments and save space due to duplicates and lighten the DB size.

Migration scripts included.
[UPD] Update github_connector_odoo.pot
TT25583

[UPD] Update github_connector_odoo.pot

[UPD] README.rst

github_connector_odoo 14.0.2.0.0
… to _for_xml_id()

github_connector_odoo 14.0.2.1.0
[UPD] Update github_connector_odoo.pot
WARNING devel py.warnings: /github_connector_odoo/models/github_repository_branch.py:232:
DeprecationWarning: load_information_from_description_file() is a deprecated alias to get_manifest()

[BOT] post-merge updates
TT48258

[UPD] Update github_connector_odoo.pot

[BOT] post-merge updates

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: interface-github-16.0/interface-github-16.0-github_connector_odoo
Translate-URL: https://translation.odoo-community.org/projects/interface-github-16-0/interface-github-16-0-github_connector_odoo/
Translated using Weblate (Italian)

Currently translated at 100.0% (136 of 136 strings)

Translation: interface-github-16.0/interface-github-16.0-github_connector_odoo
Translate-URL: https://translation.odoo-community.org/projects/interface-github-16-0/interface-github-16-0-github_connector_odoo/it/
- Internal implementation of get_manifest (with load_file/load_path)
  was rejecting the manifest path as not being in its addons_path.
- Image resizing was not done correctly

[BOT] post-merge updates
@victoralmau victoralmau force-pushed the 17.0-mig-github_connector_odoo branch from 3fc55bf to 92d442f Compare November 11, 2024 08:20
@victoralmau victoralmau marked this pull request as ready for review November 11, 2024 08:20
@victoralmau
Copy link
Member Author

The error in the tests is a reflection of a curious thing, the adapt_version() method has changed from v16 to v17 causing it to now fail. What solution do you propose?

@victoralmau victoralmau force-pushed the 17.0-mig-github_connector_odoo branch from 92d442f to bc91f6c Compare November 12, 2024 08:03
@victoralmau
Copy link
Member Author

It's ready to review now.

@pedrobaeza
Copy link
Member

/ocabot migration github_connector_odoo

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Nov 13, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 13, 2024
2 tasks
github_connector_odoo/monkeypatching.py Outdated Show resolved Hide resolved
@victoralmau victoralmau force-pushed the 17.0-mig-github_connector_odoo branch from bc91f6c to 77d136e Compare November 13, 2024 07:43
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-129-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 82d6065 into OCA:17.0 Nov 14, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3a3a65b. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 17.0-mig-github_connector_odoo branch November 14, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.