Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] account_invoice_change_currency: Migration to 15.0 #1161

Merged
merged 30 commits into from
May 19, 2022
Merged

[MIG] account_invoice_change_currency: Migration to 15.0 #1161

merged 30 commits into from
May 19, 2022

Conversation

rolandojduartem
Copy link
Contributor

No description provided.

Duc Dao and others added 29 commits May 17, 2022 11:59
@rolandojduartem
[ADD] Add module account_invoice_change_currency
824fb71 
[UPD] Update account_invoice_change_currency.pot
@rolandojduartem
[MIG] account_invoice_change_currency: Migration to 11.0
d6167b1
@hugho-ad @rolandojduartem
[12.0] account_invoice_change_currency migrate to v12.0
73c45d4 
[REF] Update readme file

[UPD] README.rst

[UPD] Update account_invoice_change_currency.pot
@hugho-ad @rolandojduartem
[REF] Move change currency button to a better place inside the invoic…
a7d0a77 
…e form

[UPD] README.rst
@hugho-ad @rolandojduartem
[IMP] Avoid open extra_view
dbed04e 
[IMP] Avoid store old currency in new field, instead of get it from tracking values from messages

[UPD] README.rst

[UPD] Update account_invoice_change_currency.pot
@hugho-ad @rolandojduartem
[IMP]account_invoice_change_currency: Allow use a custom rate at conv…
1d2136b 
…ertion

[IMP] account_invoice_change_currency: Allow set a a custom rate at currency conversion

[UPD] README.rst

[UPD] Update account_invoice_change_currency.pot
@hugho-ad @rolandojduartem
[FIX] account_invoice_change_currency: the custom_rate field has a ba…
b41c600 
…d position in supplier invoices. (OCA#458)
@pedrobaeza @rolandojduartem
Added translation using Weblate (Spanish)
0b6f372
@pedrobaeza @rolandojduartem
Added translation using Weblate (Spanish (Mexico))
7019568
@hugho-ad @rolandojduartem
[FIX] Fixed performance problem when search tracking values by subtype (
684b8d8 
OCA#470)

id, instead search them by messages ids then filter them
fix OCA#469

[REF] account_invoice_change_currency: Sql queries in order to improve performance

[FIX] account_invoice_change_currency: Fixed tests
@hugho-ad @rolandojduartem
[FIX] account_invoice_change_currency: Failing when new invoice
291dce3 
created, newid record not consider at onchange and get_last_currency
method

[UPD] Update account_invoice_change_currency.pot

Update translation files

Updated by Update PO files to match POT (msgmerge) hook in Weblate.
@mvrodriguez @rolandojduartem
Translated using Weblate (Spanish)
05f18a1 
Currently translated at 25.0% (2 of 8 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_change_currency
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_change_currency/es/
@OCA-git-bot @rolandojduartem
[ADD] icon.png
5452f54
@BECJIE32 @rolandojduartem
Translated using Weblate (Spanish)
98f1b79 
Currently translated at 87.5% (7 of 8 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_change_currency
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_change_currency/es/
@BECJIE32 @rolandojduartem
Translated using Weblate (Spanish)
3f328c2 
Currently translated at 100.0% (8 of 8 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_change_currency
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_change_currency/es/
@marylla @rolandojduartem
Added translation using Weblate (German)
5a76eab
@marylla @rolandojduartem
Translated using Weblate (German)
e876feb 
Currently translated at 12.5% (1 of 8 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_change_currency
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_change_currency/de/
@josepmy @rolandojduartem
Translated using Weblate (Spanish)
c028ad7 
Currently translated at 100.0% (8 of 8 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_change_currency
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_change_currency/es/

[UPD] README.rst
@marylla @rolandojduartem
Translated using Weblate (German)
1dcb4aa 
Currently translated at 25.0% (2 of 8 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_change_currency
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_change_currency/de/
@MiquelRForgeFlow @rolandojduartem
[FIX] Check if 'tracking_disable' is in context
7a7dee3
@hugho-ad @rolandojduartem
[REF] account_invoice_change_currency: Fixed get rate at first currency
e04d7cd 
convertion.

Before this commit, was returned the same currency that the invoice on
the onchange context, now is returned the currency recorded at the
messages with tracking values.
@badbole @rolandojduartem
Added translation using Weblate (Croatian)
2e51f62
@badbole @rolandojduartem
Translated using Weblate (Croatian)
11e4e62 
Currently translated at 75.0% (6 of 8 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_change_currency
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_change_currency/hr/
@hugho-ad @rolandojduartem
[FIX] account_invoice_change_currency: Rounding price_unit & tax amou…
6712b52 
…nt after convertions
@OCA-git-bot @rolandojduartem
account_invoice_change_currency 12.0.1.1.0
b5a21e8
@marylla @rolandojduartem
Translated using Weblate (German)
d493c86 
Currently translated at 62.5% (5 of 8 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_change_currency
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_change_currency/de/
@Saran440 @rolandojduartem
[IMP] account_invoice_change_currency: black, isort, prettier
f3d9f26
@Saran440 @rolandojduartem
[13.0][MIG] account_invoice_change_currency
9514a1d
@rolandojduartem
[MIG] account_invoice_change_currency: Migration to 14.0
0fd791c 
**Changes**

Now, the account_invoice_change_currency avoid the mail tracking using account.move, res.currency
and new fields to handle the different calculations.

**New fields**

- original_currency_id: Store the base currency when the invoice is created or the conversion is called for the first time. This is used to calculate conversion from this currency.
- is_original_currency: Check if current currency is the base currency. This is used to hide custom rate field in the form view.
- original_price_unit: Store price unit from every line when the invoice is created or the conversion is called for the first time to use it to convert the amount in the new currency.

[UPD] README.rst
@rolandojduartem rolandojduartem mentioned this pull request May 17, 2022
Open
56 tasks
@rolandojduartem rolandojduartem force-pushed the 15.0-mig-account_invoice_change_currency branch 2 times, most recently from c29d39e to 85238e8 Compare May 17, 2022 18:59
@rolandojduartem
Copy link
Contributor Author

rolandojduartem commented May 17, 2022 •
edited
Loading

Hi, @luisg123v, @moylop260 and @hugho-ad, please, may someone review this migration? T#52382

red tests are related to account_invoice_fiscal_position_update

cc @name1984 @desdelinux)

@rolandojduartem
Copy link
Contributor Author

Hi, @luisg123v, @moylop260 and @hugho-ad, please, may you review this migration? T#52382

red tests are related to account_invoice_fiscal_position_update

cc @name1984 @desdelinux

@rolandojduartem rolandojduartem force-pushed the 15.0-mig-account_invoice_change_currency branch from 6120cb9 to a8af913 Compare May 18, 2022 19:16
@moylop260
Copy link
Contributor

Could you create a new issue related to the red CI for account_invoice_fiscal_position_update module, please?

@moylop260 moylop260 merged commit f9dfc0e into OCA:15.0 May 19, 2022
@moylop260 moylop260 deleted the 15.0-mig-account_invoice_change_currency branch May 19, 2022 18:26
@rolandojduartem rolandojduartem mentioned this pull request May 19, 2022
Closed
@pedrobaeza
Copy link
Member

The red CI is due to upstream changes, as the last time. You can collaborate as well to fix it. I think this time it can be something with explicitly calling action_post that I have seen around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moylop260 moylop260 moylop260 left review comments

@luisg123v luisg123v luisg123v approved these changes

@hugho-ad hugho-ad hugho-ad approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.