[16.0][FIX]account_invoice_report_grouped_by_picking: do not show negative values with partially invoiced services #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelregidor
changed the title
manuelregidor
force-pushed
the
16.0-fix-account_invoice_report_grouped_by_picking
branch
from
0559ba4 to
ab05195
Compare
etobella
approved these changes
Mar 6, 2024
marcelsavegnago
approved these changes
Mar 6, 2024
CarlosRoca13
approved these changes
Mar 7, 2024
pedrobaeza
changed the title
pedrobaeza
requested changes
Mar 7, 2024
There was a problem hiding this comment.
Sorry for stopping this, but I see that your change impacts both lines with product, consumable or service, so this may alter some of the previous behaviors. Should you limit it to services?
Also I would like to have a test exercising the specific problem for avoiding future regressions.
manuelregidor
force-pushed
the
16.0-fix-account_invoice_report_grouped_by_picking
branch
from
ab05195 to
b7382e6
Compare
pedrobaeza
reviewed
Mar 7, 2024
account_invoice_report_grouped_by_picking/models/account_move.py
Outdated
Show resolved
Hide resolved
|
Hi @pedrobaeza Any news about this? The error is in several versions, and it should be fixed. |
|
@carlosdauden can you confirm that you see the change correct? |
pedrobaeza
reviewed
Mar 12, 2024
account_invoice_report_grouped_by_picking/models/account_move.py
Outdated
Show resolved
Hide resolved
manuelregidor
force-pushed
the
16.0-fix-account_invoice_report_grouped_by_picking
branch
from
b7382e6 to
23d8a9b
Compare
pedrobaeza
reviewed
Mar 12, 2024
account_invoice_report_grouped_by_picking/models/account_move.py
Outdated
Show resolved
Hide resolved
…values with partially invoiced services
manuelregidor
force-pushed
the
16.0-fix-account_invoice_report_grouped_by_picking
branch
from
23d8a9b to
326607d
Compare
pedrobaeza
approved these changes
Mar 12, 2024
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at c42ecab. Thanks a lot for contributing to OCA. ❤️ |
HaraldPanten
deleted the
16.0-fix-account_invoice_report_grouped_by_picking
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this fix, partially invoiced services that come from sale order lines do not show negative values in invoices PDFs grouped by pickings.
Consider the following sale order:
and the following invoice, in which the amount of the invoiced service quantity is less than the quantity ordered:
Before this fix, there were two lines for the service product: in one of them, quantity is 5, which is the amount in the sale order; in the other one, quantity is -3, which is the amount that needs to be substracted from the other line in order to obtain the amount present in the invoice:
With the fix, there is only one line in the PDF that contains the amount that is actually invoiced.
