Skip to content

Commit

Permalink
[FIX]account_invoice_report_grouped_by_picking: do not show negative …
Browse files Browse the repository at this point in the history
…values with partially invoiced services
  • Loading branch information
manuelregidor committed Mar 6, 2024
1 parent 27748ff commit ab05195
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 2 deletions.
6 changes: 5 additions & 1 deletion account_invoice_report_grouped_by_picking/README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Account Invoice Grouped by Picking
!! This file is generated by oca-gen-addon-readme !!
!! changes will be overwritten. !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! source digest: sha256:de4c4463a2aa0e1670dca3c708e6ca71ab665dded60239f6e7a61b20792fc61a
!! source digest: sha256:fa621af850264f0ff2d2219fca81d3676f300dde7b1bc668e0d215a217d86107
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
Expand Down Expand Up @@ -86,6 +86,10 @@ Contributors

* Ioan Galan <[email protected]>

* `Sygel <https://www.sygel.es>`__:

* Manuel Regidor <[email protected]>

Maintainers
~~~~~~~~~~~

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,10 @@ def lines_grouped_by_picking(self):
)
picking_dict.setdefault(key, 0)
qty = so_line.product_uom_qty
if remaining_qty < so_line.product_uom_qty:
qty = so_line.product_uom_qty - (

Check warning on line 112 in account_invoice_report_grouped_by_picking/models/account_move.py

View check run for this annotation

Codecov / codecov/patch

account_invoice_report_grouped_by_picking/models/account_move.py#L112

Added line #L112 was not covered by tests
so_line.product_uom_qty - remaining_qty
)
picking_dict[key] += qty
remaining_qty -= qty
elif not line.move_line_ids and not line.sale_line_ids:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,7 @@
* `Studio73 <https://www.studio73.es>`__:

* Ioan Galan <[email protected]>

* `Sygel <https://www.sygel.es>`__:

* Manuel Regidor <[email protected]>
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ <h1 class="title">Account Invoice Grouped by Picking</h1>
!! This file is generated by oca-gen-addon-readme !!
!! changes will be overwritten. !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! source digest: sha256:de4c4463a2aa0e1670dca3c708e6ca71ab665dded60239f6e7a61b20792fc61a
!! source digest: sha256:fa621af850264f0ff2d2219fca81d3676f300dde7b1bc668e0d215a217d86107
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/account-invoice-reporting/tree/16.0/account_invoice_report_grouped_by_picking"><img alt="OCA/account-invoice-reporting" src="https://img.shields.io/badge/github-OCA%2Faccount--invoice--reporting-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/account-invoice-reporting-16-0/account-invoice-reporting-16-0-account_invoice_report_grouped_by_picking"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/account-invoice-reporting&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
<p>This module allows print invoices with picking info. This module groups
Expand Down Expand Up @@ -433,6 +433,10 @@ <h2><a class="toc-backref" href="#toc-entry-5">Contributors</a></h2>
<li>Ioan Galan &lt;<a class="reference external" href="mailto:ioan&#64;studio73.es">ioan&#64;studio73.es</a>&gt;</li>
</ul>
</li>
<li><a class="reference external" href="https://www.sygel.es">Sygel</a>:<ul>
<li>Manuel Regidor &lt;<a class="reference external" href="mailto:manuelregidor&#64;sygel.es">manuelregidor&#64;sygel.es</a>&gt;</li>
</ul>
</li>
</ul>
</div>
<div class="section" id="maintainers">
Expand Down

0 comments on commit ab05195

Please sign in to comment.