Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][OU-ADD] fetchmail_gmail: Nothing to do #3992

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

ndd-odoo
Copy link
Contributor

@ndd-odoo ndd-odoo commented Jul 3, 2023

This module has been merged into google_gmail and it already present in apriori.py file

@ndd-odoo ndd-odoo force-pushed the v16_mig_fetch_gmail branch from a199846 to eb2bf06 Compare July 3, 2023 07:15
@@ -140,7 +140,7 @@ Module coverage 15.0 -> 16.0
+-------------------------------------------------+----------------------+-------------------------------------------------+
| |del| fetchmail | | |
+-------------------------------------------------+----------------------+-------------------------------------------------+
| |del| fetchmail_gmail | | |
| |del| fetchmail_gmail |Nothing to do |Merged into google_gmail. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| |del| fetchmail_gmail |Nothing to do |Merged into google_gmail. |
| |del| fetchmail_gmail |Done |Merged into google_gmail. |

(as there is something done in the apriori.py)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok , i write like this because i take an example from #3963, i 'll fix right away

@legalsylvain
Copy link
Contributor

/ocabot migration fetch_gmail

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jul 3, 2023
@ndd-odoo ndd-odoo force-pushed the v16_mig_fetch_gmail branch from eb2bf06 to 87574b8 Compare July 3, 2023 07:43
@ndd-odoo ndd-odoo changed the title [16.0][OU-ADD] fetch_gmail: Nothing to do [16.0][OU-ADD] fetchmail_gmail: Nothing to do Jul 3, 2023
This module has been merged into google_gmail
@ndd-odoo ndd-odoo force-pushed the v16_mig_fetch_gmail branch from 87574b8 to 4910315 Compare July 3, 2023 08:31
Copy link
Contributor

@remytms remytms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-3992-by-legalsylvain-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9c15f56. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 9c15f56 into OCA:16.0 Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants