-
-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][OU-ADD] fetchmail: nothing to do #3963
Conversation
/ocabot migration fetchmail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor remarks. Otherwise, LGTM.
docsource/modules150-160.rst
Outdated
@@ -138,7 +138,7 @@ Module coverage 15.0 -> 16.0 | |||
+-------------------------------------------------+----------------------+-------------------------------------------------+ | |||
| event_sms | |No DB layout changes. | | |||
+-------------------------------------------------+----------------------+-------------------------------------------------+ | |||
| |del| fetchmail | | | | |||
| |del| fetchmail | Nothing to do | Merged into mail. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| |del| fetchmail | Nothing to do | Merged into mail. | | |
| |del| fetchmail | Done | Merged into mail. | |
(as something is done in the apriori.py file).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the review @legalsylvain! fixed and updated git comment.
fetchmail was merged into mail without model or data changes, and it is already present in the list of merged modules in apriori.py.
518f457
to
54204b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge nobump
On my way to merge this fine PR! |
@legalsylvain your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-3963-by-legalsylvain-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
@huguesdk Could you rebase ? |
sure, but why is it needed, as there are no conflicts? the ci failed during |
let's retry. /ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 975bcfa. Thanks a lot for contributing to OCA. ❤️ |
fetchmail
was merged intomail
without model or data changes, and it is already present in the list of merged modules inapriori.py
.