Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][OU-ADD] fetchmail: nothing to do #3963

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

huguesdk
Copy link
Member

fetchmail was merged into mail without model or data changes, and it is already present in the list of merged modules in apriori.py.

@legalsylvain
Copy link
Contributor

/ocabot migration fetchmail

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jun 30, 2023
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor remarks. Otherwise, LGTM.

@@ -138,7 +138,7 @@ Module coverage 15.0 -> 16.0
+-------------------------------------------------+----------------------+-------------------------------------------------+
| event_sms | |No DB layout changes. |
+-------------------------------------------------+----------------------+-------------------------------------------------+
| |del| fetchmail | | |
| |del| fetchmail | Nothing to do | Merged into mail. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| |del| fetchmail | Nothing to do | Merged into mail. |
| |del| fetchmail | Done | Merged into mail. |

(as something is done in the apriori.py file).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the review @legalsylvain! fixed and updated git comment.

fetchmail was merged into mail without model or data changes, and it is
already present in the list of merged modules in apriori.py.
@huguesdk huguesdk force-pushed the 16.0-ou_add-fetchmail branch from 518f457 to 54204b6 Compare July 3, 2023 08:05
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-3963-by-legalsylvain-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 3, 2023
Signed-off-by legalsylvain
@OCA-git-bot
Copy link
Contributor

@legalsylvain your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-3963-by-legalsylvain-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@legalsylvain
Copy link
Contributor

@huguesdk Could you rebase ?

@huguesdk
Copy link
Member Author

huguesdk commented Jul 3, 2023

sure, but why is it needed, as there are no conflicts? the ci failed during pre-commit with the error “premature close”, as if the process was somehow aborted.

@legalsylvain
Copy link
Contributor

let's retry.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-3963-by-legalsylvain-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 975bcfa. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 975bcfa into OCA:16.0 Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants