Inverted conditional on linking user for clarity.

Nuklon · Nov 15, 2021 · fe396ba · fe396ba
1 parent c6176a0
commit fe396ba
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/src/Umbraco.Web.BackOffice/Security/BackOfficeSignInManager.cs b/src/Umbraco.Web.BackOffice/Security/BackOfficeSignInManager.cs
@@ -194,14 +194,14 @@ private async Task<SignInResult> AutoLinkAndSignInExternalAccount(ExternalLoginI
                     }
 
                     var shouldLinkUser = autoLinkOptions.OnExternalLogin == null || autoLinkOptions.OnExternalLogin(autoLinkUser, loginInfo);
-                    if (shouldLinkUser == false)
+                    if (shouldLinkUser)
                     {
-                        LogFailedExternalLogin(loginInfo, autoLinkUser);
-                        return ExternalLoginSignInResult.NotAllowed;
+                        return await LinkUser(autoLinkUser, loginInfo);
                     }
                     else
                     {
-                        return await LinkUser(autoLinkUser, loginInfo);
+                        LogFailedExternalLogin(loginInfo, autoLinkUser);
+                        return ExternalLoginSignInResult.NotAllowed;
                     }
                 }
                 else
@@ -236,14 +236,14 @@ private async Task<SignInResult> AutoLinkAndSignInExternalAccount(ExternalLoginI
                     else
                     {
                         var shouldLinkUser = autoLinkOptions.OnExternalLogin == null || autoLinkOptions.OnExternalLogin(autoLinkUser, loginInfo);
-                        if (shouldLinkUser == false)
+                        if (shouldLinkUser)
                         {
-                            LogFailedExternalLogin(loginInfo, autoLinkUser);
-                            return ExternalLoginSignInResult.NotAllowed;
+                            return await LinkUser(autoLinkUser, loginInfo);
                         }
                         else
                         {
-                            return await LinkUser(autoLinkUser, loginInfo);
+                            LogFailedExternalLogin(loginInfo, autoLinkUser);
+                            return ExternalLoginSignInResult.NotAllowed;
                         }
                     }
                 }