Added null check for external login invocation when linking users.

Nuklon · Nov 15, 2021 · c6176a0 · c6176a0
1 parent 3d43815
commit c6176a0
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/Umbraco.Web.BackOffice/Security/BackOfficeSignInManager.cs b/src/Umbraco.Web.BackOffice/Security/BackOfficeSignInManager.cs
@@ -193,8 +193,8 @@ private async Task<SignInResult> AutoLinkAndSignInExternalAccount(ExternalLoginI
                         return AutoLinkSignInResult.FailedException(ex.Message);
                     }
 
-                    var shouldSignIn = autoLinkOptions.OnExternalLogin(autoLinkUser, loginInfo);
-                    if (shouldSignIn == false)
+                    var shouldLinkUser = autoLinkOptions.OnExternalLogin == null || autoLinkOptions.OnExternalLogin(autoLinkUser, loginInfo);
+                    if (shouldLinkUser == false)
                     {
                         LogFailedExternalLogin(loginInfo, autoLinkUser);
                         return ExternalLoginSignInResult.NotAllowed;
@@ -235,8 +235,8 @@ private async Task<SignInResult> AutoLinkAndSignInExternalAccount(ExternalLoginI
                     }
                     else
                     {
-                        var shouldSignIn = autoLinkOptions.OnExternalLogin(autoLinkUser, loginInfo);
-                        if (shouldSignIn == false)
+                        var shouldLinkUser = autoLinkOptions.OnExternalLogin == null || autoLinkOptions.OnExternalLogin(autoLinkUser, loginInfo);
+                        if (shouldLinkUser == false)
                         {
                             LogFailedExternalLogin(loginInfo, autoLinkUser);
                             return ExternalLoginSignInResult.NotAllowed;