Fix incorrect json array returned for locales with comma as decimal separator in TelemetryUtility.ToJsonArrayOfTimingsInSeconds #5441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
jeffkl
previously approved these changes
Oct 2, 2023
nkolev92
reviewed
Oct 2, 2023
test/NuGet.Clients.Tests/NuGet.VisualStudio.Common.Test/Telemetry/TelemetryUtilityTests.cs
Outdated
Show resolved
Hide resolved
jeffkl
reviewed
Oct 3, 2023
src/NuGet.Clients/NuGet.VisualStudio.Common/Telemetry/TelemetryUtility.cs
Show resolved
Hide resolved
nkolev92
approved these changes
Oct 10, 2023
jeffkl
approved these changes
Oct 11, 2023
dotnokato
deleted the
dev-dotnokato-incorrect-json-array-fix-ToJsonArrayOfTimingsInSeconds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#12915
Regression? Last working version:
Description
Related to: NuGet/Home#12820
TelemetryUtility.ToJsonArrayOfTimingsInSeconds returns incorrect json array on locales having comma as a decimal separator
Running test NuGet.VisualStudio.Common.Test.Telemetry.TelemetryUtilityTests.ToJsonArrayOfTimingsInSeconds_WithMultipleValues_AppendsValuesWithComma on system with such locales (e.g.
de) fails with the following error:This PR:
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation