Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: use product resource string instead of hard-coded en-US string #12820

Closed
dtivel opened this issue Aug 17, 2023 · 5 comments · Fixed by NuGet/NuGet.Client#5442
Closed

Test: use product resource string instead of hard-coded en-US string #12820

dtivel opened this issue Aug 17, 2023 · 5 comments · Fixed by NuGet/NuGet.Client#5442
Assignees
@jeffkl
Labels
Engineering Productivity Priority:2 Issues for the current backlog. Type:Test
Milestone
6.9

Comments

@dtivel
Copy link
Contributor

dtivel commented Aug 17, 2023

It should be easy to clone the repo, build and test, irrespective of the current user's locale. There's at least one report that this workflow was not possible without first changing the locale to en-US. While the report lacks detail, I suspect that the problem is that some tests use hard-coded en-US strings (example) instead of using the product's resource string.
@dtivel dtivel mentioned this issue Aug 17, 2023
Merged
5 tasks
@nkolev92 nkolev92 added Priority:2 Issues for the current backlog. Engineering Productivity and removed Type:Bug labels Aug 17, 2023
@dotnokato
Copy link

One way to solve that could be to add -ForceEnglishOutput as one of the arguments passed to CommandRunner.Run.
Happy to submit a PR if this is an acceptable solution.

@nkolev92
Copy link
Member

Team Triage: Tests should use resource strings when possible to allow them to be runnable on machines with different locales.

@dotnokato
Copy link

dotnokato commented Aug 25, 2023 •
edited
Loading

To give more context: My machine is setup with non-English language (Polish) and non-us regional format.
When I run build.ps1, I get quite a high number of tests failing -> as of writing this comment, running on dev branch, resulted in 118 tests failing. I'll include list of those tests in a separate comment below.

To get those tests run successfully without any code changes I need to:

  • set system language to English
  • set regional format to English (United States)

Interestingly enough, setting environment variable DOTNET_CLI_UI_LANGUAGE to en-us shaves the number of tests failing by ~1/3rd, to around 70.

@dotnokato
Copy link

Test name Error
NuGet.ProjectModel.Test.JsonTextReaderExtensionsTests.ReadStringArrayAsList_WithSupportedTypes_ReturnsStringArrFaileday Assert.Collection() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: " 19. 1 9") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1 1.1.1.1") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.2.3.-4") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.1. .1") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNullOrEmpty Assert.Contains() Failure
NuGet.Protocol.Tests.PackageUpdateResourceTests.PackageUpdateResource_SymbolSourceOnlyPushingAsync System.Net.Http.HttpRequestException : Kod stanu odpowiedzi nie wskazuje powodzenia: 403 (Forbidden).
NuGet.Common.Test.CryptoHashProviderTest.CryptoHashProviderThrowsIfHashAlgorithmIsNotSHA512orSHA256(hashAlgorithm: "md5") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.2..") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.2.3.4This version is full of awesomeness!!") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.1.1.2147483648") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.-1.1.1") Assert.Contains() Failure
NuGet.Common.Test.DateTimeUtilityTests.ToReadableTimeFormat_Localized_AssumesEnglishLocale_ContainsTimeNumber_Succeeds Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "So.is.this") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1beta") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.2147483648") Assert.Contains() Failure
NuGet.Configuration.Test.SettingsTests.ResolvePathFromOrigin_WhenPathIsInvalidRelativeFileSystemPath_Throws Assert.Equal() Failure
NuGet.ProjectModel.Test.JsonPackageSpecReaderTests.GetPackageSpec_WhenCopyrightValueIsConvertibleToString_ReturnsCopyright(value: "3.14", expectedValue: "3.14") Assert.Equal() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.1 .") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.1.1.1 .") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.2.3.Beta") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.1.2147483648") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.-2.3.4") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.1.1.-1") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: " ") Assert.Contains() Failure
NuGet.ProjectModel.Test.JsonTextReaderExtensionsTests.ReadStringOrArrayOfStringsAsReadOnlyList_WhenValueIsConvertibleToString_ReturnsValueAsString(value: "3.14", expectedResult: "3.14") Assert.Collection() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "19 .1 9 ") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: " 19. 19. 19. 1 9") Assert.Contains() Failure
NuGet.DependencyResolver.Core.Tests.GraphNodeTests.GraphNode_WithDifferentHasEmptyInnerNodes_CreateInnerNodesCorrectly(hasInnerNodes: False, innerNodesHasNode: False) Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "-1.2.3.4") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.4.7+*") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.") Assert.Contains() Failure
NuGet.ProjectModel.Test.JsonPackageSpecReaderTests.GetPackageSpec_WhenAuthorsValueElementIsConvertibleToString_ReturnsAuthor(value: "3.14", expectedValue: "3.14") Assert.Collection() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.1 1.1.1") Assert.Contains() Failure
NuGet.ProjectModel.Test.JsonPackageSpecReaderTests.GetPackageSpec_WhenContentFilesValueElementIsConvertibleToString_ReturnsContentFile(value: "3.14", expectedValue: "3.14") Assert.Collection() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.4.7-AA.01^") Assert.Contains() Failure
NuGet.Common.Test.CryptoHashProviderTest.CryptoHashProviderThrowsIfHashAlgorithmIsNotSHA512orSHA256(hashAlgorithm: "SHA2561") Assert.Contains() Failure
NuGet.ProjectModel.Test.JsonPackageSpecReaderTests.GetPackageSpec_WhenFrameworksDependenciesDependencyValueIsArray_Throws(propertyName: "include") Assert.Equal() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: " 19. 19. 1 9") Assert.Contains() Failure
NuGet.Common.Test.DateTimeUtilityTests.ToReadableTimeFormat_Localized_AssumesEnglishLocale_ContainsTimeNumber_Succeeds Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.1.10000000000000000000") Assert.Contains() Failure
NuGet.ProjectModel.Test.JsonTextReaderExtensionsTests.ReadNextTokenAsString_WhenValueIsConvertibleToString_ReturnsValueAsString(value: "3.14", expectedResult: "3.14") Assert.Equal() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.1.1. ") Assert.Contains() Failure
NuGet.Common.Test.DateTimeUtilityTests.ToReadableTimeFormat_Localized_AssumesEnglishLocale_ContainsTimeNumber_Succeeds Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.34.2Release Candidate") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.1.1.1.") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: " 1 9") Assert.Contains() Failure
NuGet.Configuration.Test.SearchTreeTest.SearchTree_InvalidSearchInput_Throws(packagePatterns: "nuget.org,nuget", term: "") Assert.Equal() Failure
NuGet.Configuration.Test.SearchTreeTest.SearchTree_InvalidSearchInput_Throws(packagePatterns: " nuget.org , nuget", term: " ") Assert.Equal() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.1.1 .") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "..1") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1..2") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.1.-1.1") Assert.Contains() Failure
NuGet.Packaging.Test.ManifestTest.RejectsInvalidPackageTypeWhenValidatingSchema Assert.Equal() Failure
NuGet.Common.Test.CryptoHashProviderTest.CryptoHashProviderThrowsIfHashAlgorithmIsNotSHA512orSHA256(hashAlgorithm: "MD5") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "..1.2") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.2147483648.3.4") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "10000000000000000000") Assert.Contains() Failure
NuGet.ProjectModel.Test.JsonPackageSpecReaderTests.GetPackageSpec_WhenFrameworksDependenciesDependencyValueIsArray_Throws(propertyName: "suppressParent") Assert.Equal() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.2.-3.4") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.10000000000000000000") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "19 .19 .19 .1 9 ") Assert.Contains() Failure
NuGet.Configuration.Test.SearchTreeTest.SearchTree_InvalidSearchInput_Throws(packagePatterns: "nuget.org,nuget", term: null) Assert.Equal() Failure
NuGet.ProjectModel.Test.JsonPackageSpecReaderTests.GetPackageSpec_WhenBuildOptionsValueOutputNameIsConvertibleToString_ReturnsOutputName(outputName: "3.14", expectedValue: "3.14") Assert.Equal() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "2147483648.2.3.4") Assert.Contains() Failure
NuGet.DependencyResolver.Core.Tests.GraphNodeTests.GraphNode_WithDifferentHasEmptyParentNodes_CreateParentNodesCorrectly(hasParentNodes: False, parentNodesHasNode: False) Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1. .1.1") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "....") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1 .") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: " 19 . 1 9 ") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: " 19 . 19 . 19 . 1 9 ") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.1.1.1.2147483648") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: " 1 9 ") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1 9 ") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.1.1 1.1") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.34.2Alpha") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.2.3.2147483648") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "19 .19 .1 9 ") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.2.2147483648.4") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "-1.1.1.1") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.4.7-*") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: " .1.1.1") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.4.7-AA.0A^") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.4.7-") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.4.7+AA.01^") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: " 19 . 19 . 1 9 ") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.2.3.4.5") Assert.Contains() Failure
NuGet.Protocol.Tests.PackageUpdateResourceTests.PackageUpdateResource_GetErrorFromCreateKeyPushingAsync Assert.True() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.1.1.") Assert.Contains() Failure
NuGet.ProjectModel.Test.JsonTextReaderExtensionsTests.ReadStringArrayAsReadOnlyListFromArrayStart_WhenValuesAreConvertibleToString_ReturnsReadOnlyList Assert.Collection() Failure
NuGet.Configuration.Test.SearchTreeTest.SearchTree_InvalidSearchInput_Throws(packagePatterns: "nuget.org,nuget", term: " ") Assert.Equal() Failure
NuGet.ProjectModel.Test.JsonPackageSpecReaderTests.GetPackageSpec_WhenFrameworksDependenciesDependencyValueIsArray_Throws(propertyName: "exclude") Assert.Equal() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.4.7-A^A") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.1.1.1.10000000000000000000") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.1.") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.2Av^c") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.1.1.1 1") Assert.Contains() Failure
NuGet.Versioning.Test.NuGetVersionTest.ParseThrowsIfStringIsNotAValidSemVer(versionString: "1.1.1.1.1.") Assert.Contains() Failure
NuGet.Common.Test.CryptoHashProviderTest.CryptoHashProviderThrowsIfHashAlgorithmIsNotSHA512orSHA256(hashAlgorithm: "SHA1") Assert.Contains() Failure
NuGet.ProjectModel.Test.JsonPackageSpecReaderTests.GetPackageSpec_WhenCopyrightValueIsConvertibleToString_ReturnsCopyright(value: "3.14", expectedValue: "3.14") Assert.Equal() Failure
NuGet.ProjectModel.Test.JsonTextReaderExtensionsTests.ReadStringOrArrayOfStringsAsReadOnlyList_WhenValueIsConvertibleToString_ReturnsValueAsString(value: "3.14", expectedResult: "3.14") Assert.Collection() Failure
NuGet.ProjectModel.Test.JsonTextReaderExtensionsTests.ReadNextTokenAsString_WhenValueIsConvertibleToString_ReturnsValueAsString(value: "3.14", expectedResult: "3.14") Assert.Equal() Failure
NuGet.Common.Test.DateTimeUtilityTests.ToReadableTimeFormat_Localized_AssumesEnglishLocale_ContainsTimeNumber_Succeeds Assert.Contains() Failure
NuGet.ProjectModel.Test.JsonTextReaderExtensionsTests.ReadNextTokenAsString_WhenValueIsConvertibleToString_ReturnsValueAsString(value: "3.14", expectedResult: "3.14") Assert.Equal() Failure
NuGet.Common.Test.DateTimeUtilityTests.ToReadableTimeFormat_Localized_AssumesEnglishLocale_ContainsTimeNumber_Succeeds Assert.Contains() Failure
NuGet.ProjectModel.Test.JsonTextReaderExtensionsTests.ReadStringArrayAsList_WithSupportedTypes_ReturnsStringArray Assert.Collection() Failure
NuGet.Common.Test.DateTimeUtilityTests.ToReadableTimeFormat_Localized_AssumesEnglishLocale_ContainsTimeNumber_Succeeds Assert.Contains() Failure
NuGet.ProjectModel.Test.JsonPackageSpecReaderTests.GetPackageSpec_WhenContentFilesValueElementIsConvertibleToString_ReturnsContentFile(value: "3.14", expectedValue: "3.14") Assert.Collection() Failure
NuGet.ProjectModel.Test.JsonTextReaderExtensionsTests.ReadStringArrayAsReadOnlyListFromArrayStart_WhenValuesAreConvertibleToString_ReturnsReadOnlyList Assert.Collection() Failure
NuGet.ProjectModel.Test.JsonPackageSpecReaderTests.GetPackageSpec_WhenCopyrightValueIsConvertibleToString_ReturnsCopyright(value: "3.14", expectedValue: "3.14") Assert.Equal() Failure
NuGet.ProjectModel.Test.JsonPackageSpecReaderTests.GetPackageSpec_WhenAuthorsValueElementIsConvertibleToString_ReturnsAuthor(value: "3.14", expectedValue: "3.14") Assert.Collection() Failure
NuGet.ProjectModel.Test.JsonPackageSpecReaderTests.GetPackageSpec_WhenBuildOptionsValueOutputNameIsConvertibleToString_ReturnsOutputName(outputName: "3.14", expectedValue: "3.14") Assert.Equal() Failure
NuGet.ProjectModel.Test.JsonPackageSpecReaderTests.GetPackageSpec_WhenAuthorsValueElementIsConvertibleToString_ReturnsAuthor(value: "3.14", expectedValue: "3.14") Assert.Collection() Failure
NuGet.ProjectModel.Test.JsonTextReaderExtensionsTests.ReadStringArrayAsList_WithSupportedTypes_ReturnsStringArray Assert.Collection() Failure
NuGet.ProjectModel.Test.JsonTextReaderExtensionsTests.ReadStringOrArrayOfStringsAsReadOnlyList_WhenValueIsConvertibleToString_ReturnsValueAsString(value: "3.14", expectedResult: "3.14") Assert.Collection() Failure
NuGet.ProjectModel.Test.JsonTextReaderExtensionsTests.ReadStringArrayAsReadOnlyListFromArrayStart_WhenValuesAreConvertibleToString_ReturnsReadOnlyList Assert.Collection() Failure
NuGet.ProjectModel.Test.JsonPackageSpecReaderTests.GetPackageSpec_WhenContentFilesValueElementIsConvertibleToString_ReturnsContentFile(value: "3.14", expectedValue: "3.14") Assert.Collection() Failure
NuGet.ProjectModel.Test.JsonPackageSpecReaderTests.GetPackageSpec_WhenBuildOptionsValueOutputNameIsConvertibleToString_ReturnsOutputName(outputName: "3.14", expectedValue: "3.14") Assert.Equal() Failure

@zivkan zivkan mentioned this issue Sep 1, 2023
Merged
8 tasks
This was referenced Oct 1, 2023
Merged
Merged
@dotnokato
Copy link

I've submitted NuGet/NuGet.Client#5442 and NuGet/NuGet.Client#5441 fixing all but one tests that have been failing on my machine.

The last test failing is PackageUpdateResource_SymbolSourceOnlyPushingAsync which fails due to method under test expecting exception message in English.

In this case not sure if the test itself or rather method under test should be updated.

@jeffkl jeffkl self-assigned this Oct 3, 2023
@jgonz120 jgonz120 added this to the 6.9 milestone Jan 31, 2024
@nkolev92 nkolev92 mentioned this issue Apr 16, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffkl jeffkl

Labels
Engineering Productivity Priority:2 Issues for the current backlog. Type:Test
Projects
None yet
Milestone
6.9
5 participants
@nkolev92 @jgonz120 @dtivel @jeffkl @dotnokato