Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unblock source build failing due to fatal: transport 'file' not allowed error #4867

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

kartheekp-ms
Copy link
Contributor

@kartheekp-ms kartheekp-ms commented Oct 21, 2022

Bug

Fixes: https://github.com/NuGet/Client.Engineering/issues/1927

Regression? Last working version:

Description

Source build started failing on CI resulting in private and official build failures.

Creating empty clone at: /home/vsts/work/1/s/artifacts/source-build/self/src/submodules/Common
  Cloning into '/home/vsts/work/1/s/artifacts/source-build/self/src/submodules/Common'...
  fatal: transport 'file' not allowed
  fatal: run_command returned non-zero status for submodules/Common
  .
/home/vsts/.nuget/packages/microsoft.dotnet.arcade.sdk/6.0.0-beta.21309.7/tools/SourceBuild/SourceBuildArcadeBuild.targets(147,5): error MSB3073: The command "git submodule foreach --recursive '/home/vsts/.nuget/packages/microsoft.dotnet.arcade.sdk/6.0.0-beta.21309.7/tools/SourceBuild/git-clone-to-dir.sh  --source . --dest "/home/vsts/work/1/s/artifacts/source-build/self/src/$sm_path" --copy-wip --clean'" exited with code 128. [/home/vsts/.nuget/packages/microsoft.dotnet.arcade.sdk/6.0.0-beta.21309.7/tools/Build.proj]
##[error]PowerShell exited with code '1'.
Finishing: Build source-build

@zivkan identified that this failure is related to following issues.

The work around suggested in the above issues is to run git config --global protocol.file.allow always command.

https://vielmetti.typepad.com/logbook/2022/10/git-security-fixes-lead-to-fatal-transport-file-not-allowed-error-in-ci-systems-cve-2022-39253.html blog explains how different repositories responded to this issue. Majority of them executed the above workaround.

For example, another Microsoft repo applied the same work around. https://github.com/microsoft/go-infra/pull/71/files

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • N/A
  • Documentation

    • N/A

@kartheekp-ms kartheekp-ms requested a review from a team as a code owner October 21, 2022 17:09
@kartheekp-ms kartheekp-ms merged commit a3c2340 into dev Oct 21, 2022
@kartheekp-ms kartheekp-ms deleted the dev-kartheekp-ms-sourcebuild-workaround branch October 21, 2022 17:29
kartheekp-ms pushed a commit that referenced this pull request Dec 8, 2022
AdmiringWorm added a commit to chocolatey/NuGet.Client that referenced this pull request Dec 19, 2022
Insert 6.4.0-rc.123 into rel/d17.4 on 11/07/2022 23:47:12

* tag '6.4.0.123': (60 commits)
  fix a logic error that caused AbandonedMutexException while executing migrations (release-6.4.x) (NuGet#4895)
  unblock source build failing due to fatal: transport 'file' not allowed error (NuGet#4867) (NuGet#4874)
  Signing:  update to August 2022 CTL (NuGet#4791) (NuGet#4850)
  Merged PR 422933: Prefer BCL Directory create API over helper class (7.0.1xx-rc2)
  Fix empty combobox when package is not present in project file (NuGet#4844) (NuGet#4848)
  Fix component detection alert for microsoft.owin package (NuGet#4841) (NuGet#4845)
  Make release label RC, move to escrow mode
  Adds special case to include transitive origins in GetInstalledAndTransitivePackagesAsync API (NuGet#4824)
  Add longPathAware manifest to NuGet.Build.Tasks.Console (NuGet#4830)
  VsPackageInstallerServices should not post ProjectNotNominatedException faults (NuGet#4814)
  Skip test GetOrCreateAsync_WithUnhandledExceptionInPlugin_Throws (NuGet#4831)
  Improve OptProf pipeline job run names (NuGet#4825)
  Increase HttpClientHandler.MaxConnectionsPerServer to 64 to improve PM UI performance in Visual Studio (NuGet#4798)
  Suppress CA2213 warnings to unblock dev branch (NuGet#4823)
  Ensure IsVsOfflineFeed is calculated correctly on 64-bit machines (NuGet#4817)
  Add better handling of AggregateExceptions in static graph-based restore (NuGet#4809)
  Add Component Detection task into each pipeline (NuGet#4813)
  Localizes nuget.exe with default, embedded resource assembly lookup (NuGet#4773)
  Removes BrowseObjectBase class in NuGet Solution Explorer (NuGet#4807)
  Improve TryCreateContext  (NuGet#4762)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants