Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes BrowseObjectBase class in NuGet Solution Explorer #4807

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

dominoFire
Copy link
Contributor

Bug

Fixes: NuGet/Home#9619

Regression? Last working version: N/A

Description

  • Removed BrowseObjectBase class and all of its references
  • Replaces BrowseObjectBase references with LocalizableProperties class

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception: Current tests should cover this scenario
    • OR
    • N/A
  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A: No product changes

@dominoFire dominoFire requested a review from a team as a code owner September 17, 2022 05:13
@dominoFire dominoFire changed the title Removed BrowseObjectBase class in NuGet Solution Explorer Removes BrowseObjectBase class in NuGet Solution Explorer Sep 17, 2022
@dominoFire
Copy link
Contributor Author

Tested in VS 2022 17.3 Release

image

@dominoFire dominoFire merged commit 0e8abff into dev Sep 20, 2022
@dominoFire dominoFire deleted the dev-dominofire-remove-browseobjectbase branch September 20, 2022 18:13
AdmiringWorm added a commit to chocolatey/NuGet.Client that referenced this pull request Dec 19, 2022
Insert 6.4.0-rc.123 into rel/d17.4 on 11/07/2022 23:47:12

* tag '6.4.0.123': (60 commits)
  fix a logic error that caused AbandonedMutexException while executing migrations (release-6.4.x) (NuGet#4895)
  unblock source build failing due to fatal: transport 'file' not allowed error (NuGet#4867) (NuGet#4874)
  Signing:  update to August 2022 CTL (NuGet#4791) (NuGet#4850)
  Merged PR 422933: Prefer BCL Directory create API over helper class (7.0.1xx-rc2)
  Fix empty combobox when package is not present in project file (NuGet#4844) (NuGet#4848)
  Fix component detection alert for microsoft.owin package (NuGet#4841) (NuGet#4845)
  Make release label RC, move to escrow mode
  Adds special case to include transitive origins in GetInstalledAndTransitivePackagesAsync API (NuGet#4824)
  Add longPathAware manifest to NuGet.Build.Tasks.Console (NuGet#4830)
  VsPackageInstallerServices should not post ProjectNotNominatedException faults (NuGet#4814)
  Skip test GetOrCreateAsync_WithUnhandledExceptionInPlugin_Throws (NuGet#4831)
  Improve OptProf pipeline job run names (NuGet#4825)
  Increase HttpClientHandler.MaxConnectionsPerServer to 64 to improve PM UI performance in Visual Studio (NuGet#4798)
  Suppress CA2213 warnings to unblock dev branch (NuGet#4823)
  Ensure IsVsOfflineFeed is calculated correctly on 64-bit machines (NuGet#4817)
  Add better handling of AggregateExceptions in static graph-based restore (NuGet#4809)
  Add Component Detection task into each pipeline (NuGet#4813)
  Localizes nuget.exe with default, embedded resource assembly lookup (NuGet#4773)
  Removes BrowseObjectBase class in NuGet Solution Explorer (NuGet#4807)
  Improve TryCreateContext  (NuGet#4762)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace BrowseObjectBase with LocalizableProperties once updated shell package available
4 participants