InvariantCulture flag for Regex with IgnoreCase flag

[dominoFire]

Bug

Fixes: NuGet/Home#8246
Regression: Yes

• Last working version: dotnet.exe 2.2.x
• How are we preventing it in future: Add more integration tests

Fix

Adds Culture Invariant comparison for path matching for files

Testing/Validation

Tests Added: Yes
Validation: Manual validation on dotnet (Linux Version) in WSL.

[danmoseley]

@dominoFire I see 8 other instances in NuGet.Client of RegexOptions.IgnoreCase that does not also have RegexOptions.CultureInvariant. Several them seem to be applying to file system paths. Do any of hte others need the same change?

cc @tarekgh @ericstj

[nkolev92]

Maybe we should make the changes to all the regex's dealing with apths like @danmosemsft and @ericstj are suggesting.

[zivkan]

+1 to using RegexOptions.CultureInvariant in more places. I don't think that NuGet ever needs a culture-specific regex, so I suggest using RegexOptions.CultureInvariant in every Regex (but check regex expressions, in case I'm wrong).

[danmoseley]

@dominoFire are you planning to complete this PR? It has broken our build in the past so we'd be happy to see the fix merged. thanks!

[nkolev92]

@dominoFire 🔔

Please either address feedback or close.

[aortiz-msft]

🕐

[aortiz-msft]

extra empty line

---

Refers to: test/NuGet.Core.Tests/NuGet.Protocol.Tests/ServiceTypesTests.cs:25 in 8c4f7c7. [](commit_id = 8c4f7c7, deletion_comment = False)

[aortiz-msft]

[danmoseley]

thanks @dominoFire