Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pack, and several other code paths, fails dependant on locale. Use RegexOptions.CultureInvariant #8246

Closed
ericstj opened this issue Jun 20, 2019 · 1 comment · Fixed by NuGet/NuGet.Client#2901
Assignees
Labels
Category:Quality Week Issues that should be considered for quality week Functionality:Pack Platform:Xplat Type:Bug

Comments

@ericstj
Copy link

ericstj commented Jun 20, 2019

NuGet product used (NuGet.exe | VS UI | Package Manager Console | dotnet.exe):
dotnet.exe

NuGet version (x.x.x.xxx):
5.2.0.6020

dotnet.exe --version (if appropriate):
3.0.100-preview6-012264

VS version (if appropriate):
n/a

OS version (i.e. win10 v1607 (14393.321)):
Ubuntu in WSL Version 10.0.18362 Build 18362

Worked before? If so, with which NuGet version:
don't know

Detailed repro steps so we can see the same problem

  1. Create a nuspec containing a file path with capital letters and pack with PackageBuilder.

Expect: pack succeeds.
Actual: failure to pack complaining file doesn't exist, though it does.

For more details see https://github.com/dotnet/corefx/issues/38608

Bug is here: https://github.com/NuGet/NuGet.Client/blob/686dd6b060639a0fb401eceb4c3a4029c1482023/src/NuGet.Core/NuGet.Common/PathUtil/PathResolver.cs#L90

It needs RegexOptions.CultureInvariant. Probably some other cases of the same bug https://github.com/NuGet/NuGet.Client/search?q=RegexOptions.IgnoreCase&unscoped_q=RegexOptions.IgnoreCase

@danmoseley
Copy link

@dominoFire can you help set my expectations for completing your PR? this would help our customers using WSL who periodically hit this when trying to build.

@dominoFire dominoFire added this to the Sprint 167 - 2020.03.02 milestone Mar 2, 2020
@dominoFire dominoFire added the Category:Quality Week Issues that should be considered for quality week label Mar 2, 2020
dominoFire added a commit to NuGet/NuGet.Client that referenced this issue Mar 18, 2020
@rrelyea rrelyea changed the title Pack fails on systems with LANG=C.UTF-8 Pack, and several other code paths, fails dependant on locale. Use RegexOptions.CultureInvariant May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Quality Week Issues that should be considered for quality week Functionality:Pack Platform:Xplat Type:Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants