Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/5.0.2 - Fix override custom tags by default tags #698

Merged
merged 2 commits into from
Jul 16, 2020
Merged

Hotfix/5.0.2 - Fix override custom tags by default tags #698

merged 2 commits into from
Jul 16, 2020

Conversation

supercid
Copy link
Member

Description

On the product builder, amendAttributeTags(); was being called before $nostoProduct->setTag1();.
Internally, amendAttributeTags();uses addTag1(), which is overriden by the set called right after

Related Issue

Closes #697

How Has This Been Tested?

Locally building product and adding custom tags to tag1

Documentation:

N/A

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • I have assigned the correct milestone or created one if non-existent.
  • I have correctly labeled this pull request.
  • I have linked the corresponding issue in this description.
  • I have updated the corresponding Jira ticket.
  • I have requested a review from at least 2 reviewers
  • I have checked the base branch of this pull request
  • I have checked my code for any possible security vulnerabilities

@supercid supercid added the bug label Jul 16, 2020
@supercid supercid added this to the 5.0.2 milestone Jul 16, 2020
@supercid supercid requested a review from fairlane July 16, 2020 07:03
@supercid supercid self-assigned this Jul 16, 2020
@supercid supercid merged commit 6b11c79 into master Jul 16, 2020
@supercid supercid deleted the hotfix/override-attributes-to-tags branch July 16, 2020 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fairlane fairlane fairlane approved these changes

Assignees

@supercid supercid

Labels
bug
Projects
None yet
Milestone
5.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@supercid @fairlane