Skip to content

Commit

Permalink
Merge pull request #698 from Nosto/hotfix/override-attributes-to-tags
Browse files Browse the repository at this point in the history
  • Loading branch information
supercid authored Jul 16, 2020
2 parents 93fac09 + 2a5b389 commit 6b11c79
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 3 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
All notable changes to this project will be documented in this file. This project adheres to Semantic Versioning.

# 5.0.2
* Fix an issue where custom tags (tag1) were overridden by default tags

# 5.0.1
* Fix an issue with configurable product prices being zero in Nosto product data when taxes are included in display prices

Expand Down
2 changes: 1 addition & 1 deletion Model/Product/Builder.php
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,6 @@ public function build(
}
$nostoProduct->setCustomFields($this->getCustomFieldsWithAttributes($product, $store));
// Update customised Tag1, Tag2 and Tag3
$this->amendAttributeTags($product, $nostoProduct, $store);
if ($this->getDataHelper()->isAltimgTaggingEnabled($store)) {
$nostoProduct->setAlternateImageUrls($this->buildAlternativeImages($product, $store));
}
Expand All @@ -245,6 +244,7 @@ public function build(
if (($tags = $this->buildDefaultTags($product, $store)) !== []) {
$nostoProduct->setTag1($tags);
}
$this->amendAttributeTags($product, $nostoProduct, $store);
$brandAttribute = $this->getDataHelper()->getBrandAttribute($store);
if ($product->hasData($brandAttribute)) {
$nostoProduct->setBrand(
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "nosto/module-nostotagging",
"description": "Increase your conversion rate and average order value by delivering your customers personalized product recommendations throughout their shopping journey.",
"type": "magento2-module",
"version": "5.0.1",
"version": "5.0.2",
"require-dev": {
"php": ">=7.1.0",
"phpmd/phpmd": "^2.5",
Expand Down
2 changes: 1 addition & 1 deletion etc/module.xml
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,5 @@
<!--suppress XmlUnboundNsPrefix -->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
<module name="Nosto_Tagging" setup_version="5.0.1"/>
<module name="Nosto_Tagging" setup_version="5.0.2"/>
</config>

0 comments on commit 6b11c79

Please sign in to comment.