Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with non generated proxy classes during di compilation #666

Merged
merged 4 commits into from
Mar 31, 2020
Merged

Fix issue with non generated proxy classes during di compilation #666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
abcc5fe
Fix issue with non generated proxy classes during di compilation
Mar 30, 2020
d0b9ac9
Remove redundant proxies from cron command
Mar 30, 2020
461101b
Temporarily change the version
Mar 30, 2020
f63922d
Set version back to 4.0.6
Mar 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
All notable changes to this project will be documented in this file. This project adheres to Semantic Versioning.

# 4.0.6
* Fix issue with non-generated proxy classes during di compilation

# 4.0.5
* Fix an issue where product cache table was not created during upgrade

Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "nosto/module-nostotagging",
"description": "Increase your conversion rate and average order value by delivering your customers personalized product recommendations throughout their shopping journey.",
"type": "magento2-module",
"version": "4.0.5",
"version": "4.0.6",
"require-dev": {
"php": ">=7.1.0",
"phan/phan": "0.8.8",
Expand Down
22 changes: 5 additions & 17 deletions etc/di.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,11 @@
</argument>
</arguments>
</type>
<type name="Nosto\Tagging\Cron\ProductDataCron">
<arguments>
<argument name="batchSize" xsi:type="number">1000</argument>
</arguments>
</type>
<type name="Nosto\Tagging\Console\Command\NostoRebuildInvalidProductData">
<arguments>
<argument name="productDataCron" xsi:type="object">Nosto\Tagging\Cron\ProductDataCron\Proxy</argument>
Expand Down Expand Up @@ -223,23 +228,6 @@
<argument name="productLimit" xsi:type="number">1000</argument>
</arguments>
</type>
<type name="Nosto\Tagging\Cron\ProductDataCron">
<arguments>
<argument name="nostoAccountHelper" xsi:type="object">
Nosto\Tagging\Helper\Account\Proxy
</argument>
<argument name="nostoDataHelper" xsi:type="object">
Nosto\Tagging\Helper\Data\Proxy
</argument>
<argument name="cacheRepository" xsi:type="object">
Nosto\Tagging\Model\Product\Cache\CacheRepository\Proxy
</argument>
<argument name="cacheService" xsi:type="object">
Nosto\Tagging\Model\Service\Cache\CacheService\Proxy
</argument>
<argument name="batchSize" xsi:type="number">1000</argument>
</arguments>
</type>
<type name="Nosto\Tagging\Model\Service\Sync\Upsert\AsyncBulkPublisher">
<arguments>
<argument name="asyncBulkConsumer" xsi:type="object" shared="false">
Expand Down
2 changes: 1 addition & 1 deletion etc/module.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,5 @@
<!--suppress XmlUnboundNsPrefix -->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
<module name="Nosto_Tagging" setup_version="4.0.5"/>
<module name="Nosto_Tagging" setup_version="4.0.6"/>
</config>