Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with non generated proxy classes during di compilation #666

Merged
merged 4 commits into from
Mar 31, 2020
Merged

Fix issue with non generated proxy classes during di compilation #666

merged 4 commits into from
Mar 31, 2020

Conversation

fairlane
Copy link
Contributor

@fairlane fairlane commented Mar 30, 2020 •
edited
Loading

Description

Remove proxy definitions for ProductDataCron as the those are not generated during setup:di:compile.

Related Issue

#662

Motivation and Context

The cron command throws an error read-only filesystem (such as Magento cloud) as the proxy class cannot be created on the fly.

How Has This Been Tested?

Tested locally and in our test cloud.

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • I have assigned the correct milestone or created one if non-existent.
  • I have correctly labeled this pull request.
  • I have linked the corresponding issue in this description.
  • I have updated the corresponding Jira ticket.
  • I have requested a review from at least 2 reviewers
  • I have checked the base branch of this pull request
  • I have checked my code for any possible security vulnerabilities

@fairlane fairlane changed the base branch from develop to master March 30, 2020 17:35
@fairlane fairlane added this to the 4.0.6 milestone Mar 30, 2020
@fairlane fairlane linked an issue Mar 30, 2020 that may be closed by this pull request
Class Nosto\Tagging\Model\Product\Cache\CacheRepository\Proxy does not exist #662
Closed
6 tasks
@fairlane fairlane added the bug label Mar 30, 2020
@fairlane fairlane self-assigned this Mar 30, 2020
@fairlane fairlane requested review from supercid and olsi-qose March 30, 2020 17:36
@fairlane fairlane merged commit 351e64a into master Mar 31, 2020
@fairlane fairlane deleted the hotfix/4.0.6 branch March 31, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olsi-qose olsi-qose olsi-qose approved these changes

@supercid supercid supercid approved these changes

Assignees

@fairlane fairlane

Labels
bug
Projects
None yet
Milestone
4.0.6
Development

Successfully merging this pull request may close these issues.

Class Nosto\Tagging\Model\Product\Cache\CacheRepository\Proxy does not exist
3 participants
@fairlane @supercid @olsi-qose