Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled parameterized wave forcing of Langmuir mixing. #481

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

matsbn
Copy link
Contributor

@matsbn matsbn commented Feb 5, 2025

Enabled parameterized wave forcing to drive Langmuir mixing according to Li et al. (2016) and as implemented in CVMix.

This modification has been quite extensively tested in OMIP2 simulations and was also used in the simulation NorESMhub/noresm3_dev_simulations#68 based on the noresm2_5_alpha08d tag. There is no change with isopycnic vertical coordinate.

@matsbn matsbn mentioned this pull request Feb 5, 2025
4 tasks
Copy link
Contributor

@TomasTorsvik TomasTorsvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me

@TomasTorsvik TomasTorsvik added the enhancement New feature or request label Feb 6, 2025
@TomasTorsvik TomasTorsvik added this to the release v1.7.1 tag milestone Feb 6, 2025
@TomasTorsvik TomasTorsvik linked an issue Feb 6, 2025 that may be closed by this pull request
4 tasks
@TomasTorsvik TomasTorsvik removed a link to an issue Feb 6, 2025
4 tasks
@TomasTorsvik
Copy link
Contributor

@matsbn - Will this PR eliminate the need to run with the mod_difdia.F90 sourcemod when testing NorESM2.5/3.0?

@matsbn
Copy link
Contributor Author

matsbn commented Feb 10, 2025

@matsbn - Will this PR eliminate the need to run with the mod_difdia.F90 sourcemod when testing NorESM2.5/3.0?

Do you mean mod_difest.F90, @TomasTorsvik ?

This PR just changes namelist options of already available functionality. The PR #480 updates mod_difest.F90 consistently with what I have used as a SourceMod in recent NorESM2.5/3.0 testing.

@TomasTorsvik
Copy link
Contributor

@matsbn - yes, I ment mod_difest.F90.
That's good to know, then we don't need to include sourcemods once we build with v1.7.1.

@matsbn matsbn merged commit 350c0a1 into NorESMhub:master Feb 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants