Filtering of squared buoyancy frequency and Richardson number #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o reduced noise in vertical diffusivity when using KPP.
… mixing (RI0) when not using isopycnic vertical coordinate.
TomasTorsvik
approved these changes
Feb 5, 2025
phy/mod_difest.F90
Outdated
| bvf_i(kk+1) = sqrt( max( bfsqi(i,j,kk+1), 0.) ) | ||
| bvfsq_i(kk+1) = bvfsq_i(kk) | ||
|
|
||
| do n_iter = 1, 1 !n_smooth_ri |
There was a problem hiding this comment.
If I understand correctly, this loop will smooth rig_i and bvfsq_i N times (default N=1).
I would prefer either (1) to define the loop as do niter = 1, n_smooth_ri , and then define the n_smooth_ri parameter somewhere above, or (2) remove the loop if it will not be used.
There was a problem hiding this comment.
Thanks, for seeing this @TomasTorsvik. I have pushed a commit to remove these unnecessary loops.
phy/mod_difest.F90
Outdated
| @@ -1250,6 +1288,15 @@ subroutine difest_vertical_hyb(m,n,mm,nn,k1m,k1n) | |||
| rig_i(kk+1) = rig_i(kk) | |||
| bvfsq_i(kk+1) = bfsqi(i,j,kk+1) | |||
|
|
|||
| do n_iter = 1, 1 !n_smooth_ri | |||
There was a problem hiding this comment.
Same comment as above.
milicak
approved these changes
Feb 10, 2025
This was referenced Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filtering of squared buoyancy frequency and Richardson number has been added to reduced noise in vertical diffusivity when using KPP. Along with the filtering, the critical gradient Richardson number for shear driven vertical mixing has also been adjusted.
This modification has been quite extensively tested in OMIP2 simulations and was also used in the simulation NorESMhub/noresm3_dev_simulations#68 based on the noresm2_5_alpha08d tag. There is no change with isopycnic vertical coordinate.