Fixup CI #63
Merged
Fixup CI #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well that didn't go as expected 😕 |
|
I don't know much about the actions stuff, so I'll trust your judgement with this. |
|
I don't know much about Github Actions either, but ok, pushed to main 😄
Since that thinking is incorrect, and IIUC it's currently not (fully or safely) possible to make PR runs use our workflow file from @NoahTheDuke Could you please configure Actions settings for this repo to "Require approval for all outside collaborators" if it's not set that way already? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that
just's CI does not useactions/cache, they instead useSwatinem/rust-cache. For us it looks (based on testing in a personal fork) following suit would fixes #55 by preventing unnecessary rebuilds. So this PR makes this change.This also removes use of deprecated node16 from our CI.
Additionally, noticed that the "Check for forbidden words" is not working. This check is anyway not desirable: if it were working as intended, it would flag things that SHOULD be committed (e.g. Todo syntax highlighting). So this has been removed.
This PR is intended for manual review: I would expect this to fail CI in the PR, but pass CI when pushed to main.