Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching not working as intended? #55

Closed
laniakea64 opened this issue Nov 1, 2023 · 0 comments · Fixed by #63
Closed

Caching not working as intended? #55

laniakea64 opened this issue Nov 1, 2023 · 0 comments · Fixed by #63
Labels
bug Something isn't working ci

Comments

@laniakea64
Copy link
Collaborator

IIUC, our CI is supposed to cache

  1. Rust crate dependencies downloaded into ~/.cargo,
  2. The last test runner build (target directory).

Looking at CI logs from latest push, (2) seems either not working or useless: although the cache was correctly restored and no test runner changes were made since previous push, CI looks to have rebuilt the test runner from scratch.

If it's going to recompile everything anyway, should we make this the defined behavior? i.e. remove the attempt to cache target, and have the cache key based only on Cargo.lock, not on our Rust code. This would also save cache space and result in more cache reuse: no longer would a from-scratch cache be necessary for Rust code changes that do not change dependencies.

Alternatively, do we want to keep the current caching scheme, investigate why CI is compiling more than needed and adjust it so it stops doing that?

Not going to unilaterally go ahead try something different in this area, since not sure if messing with this in the wrong way might unintentionally result in incurring additional bills on @NoahTheDuke's Github account? 😨

@laniakea64 laniakea64 added ci bug Something isn't working labels Nov 1, 2023
@laniakea64 laniakea64 mentioned this issue Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant