-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: Tighten deps #99401
cmake: Tighten deps #99401
Conversation
pkg-config now has a target-sensative wrapper. We shouldn't rebuild CMake because that wrapper changes. The setup hook should also be a build time dep. Fix NixOS#99325
- OpenSSL is evidentally an optional dep. I guess pkg-config found it before because it was a transitive dep? - `zstd` and cross-built CMake can get by with a `cmakeMinimal that we use during bootstrapping, so let's restrict to that.
Don't we put overrides for bootstrapping elsewhere? |
If it's more complex, I think it's better to keep an option in the expression itself, as it's less likely that a change will clash with those overrides. EDIT: though here it just switches defaults to other parameters (and |
Yeah the Darwin bootstrapping just used the |
Ofborg is stalled, but I built the Darwin stdenv by hand. |
Ofborg for darwin is a "known problem": NixOS/ofborg#529 (comment) |
Motivation for this change
OpenSSL is evidentally an optional dep. I guess pkg-config found it
before because it was a transitive dep?
zstd
and cross-built CMake can get by with a `cmakeMinimal that weuse during bootstrapping, so let's restrict to that.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)