Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake gets rebuilt for cross because of run-time dependency on pkg-config #99325

Closed
Ericson2314 opened this issue Oct 1, 2020 · 2 comments
Closed

Comments

@Ericson2314
Copy link
Member

I try to do some weird cross and notice that cmake is being rebuilt. That's odd.

Here's why:

  1. pkg-config now has a target-specific wrapper.
  2. CMake has long had a run-time dep on package config

So either we give CMake a wrapper too (ugh...) or we just remove pkg-config from buildDepends of CMake. I learn towards the latter.

CC @matthewbauer and @LnL7, who I think added the dep?

@LnL7
Copy link
Member

LnL7 commented Oct 1, 2020

I only made some dependencies optional at some point to reduce the number of things needed to bootstrap. What's the issue exactly? If you mean moving pkgconfig to nativeBuildInputs then that sounds fine to me.

@Ericson2314
Copy link
Member Author

Ericson2314 commented Oct 2, 2020

What's the issue exactly?

CMake is rebuilt when it's target platform changes..

If you mean moving pkgconfig to nativeBuildInputs then that sounds fine to me.

Oh, I assume it had some nativeBuildInputs and so it was in buildInputs in purpose, but maybe it wasn't!

Also, do we know what the setup hook is a buildInput?

Oh yeah, because CMake kinda bootstraps itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants