-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vimPlugins.coc-*: add npm dependencies #82578
Conversation
@@ -125,6 +126,78 @@ self: super: { | |||
''; | |||
}); | |||
|
|||
coc-css = buildVimPluginFrom2Nix { | |||
pname = "coc-css"; | |||
version = nodePackages.coc-css.version; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apparently, this cannot be seen:
attribute 'coc-css' missing ... pkgs/misc/vim-plugins/overrides.nix:131:15
https://gist.github.com/GrahamcOfBorg/69f8e0bd962f1ce6fc88277a0d6fecce
I'm not sure if any of the added extensions in this PR require this but can I suggest adding the $HOME fix to this commit as well: Considering that this commit also adds UPDATE: Oh, it's just been merged. |
There are 32 vim plugins, all related to the coc.nvim LSP plugin, that are actually node packages and are included in nodePackages. In #82578, those vim plugins were made to point at the corresponding node packages, which fixed issues where the sources weren't being compiled properly with Javascript build systems. The way each of those vim plugins wraps its corresponding node package is identical, so I factored that out into a function and eliminated the duplication. In addition, for some reason coc-go got missed, which led to it not working correctly for me. I included it in my list of packages to wrap, so that fixes that issue.
Motivation for this change
These plugins do not work, without having the npm package, as it needs to be build beforehand.
Things done
Added all the npm packages that exists for the plugins.
Small snippets used at the bottom.
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)Things used to generated this
Find all current packages
Output this to a file coc-vimplugins.txt.
OUtput to new file, then
cat coc-vimplugins-npm.txt | xargs -I "{}" echo ', "{}"'
, and add to node-packagesv10.json.Now override them all in vim-plugins-overrides.nix.
@adisbladis go go! ;)