vimPlugins.coc-prettier: Add override

[ersinakinci]

Motivation for this change

This PR adds an override for vimPlugins.coc-prettier as a partial fix for #64560. Depends on #72501. Previously depended on #72501, which has now been squashed into this PR.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

Notify maintainers

cc @rvolosatovs

[jonringer]

since the 2 commits are necessary to perform the fix, do you mind squashing them both with the commit message:

vimPlugins.coc-prettier: Add node dependency

[ersinakinci]

@jonringer done!

[jonringer]

@GrahamcOfBorg build vimPlugins.coc-prettier

[jonringer]

hmm, im just not sure about the several thousand node packages bump ... :(

[rvolosatovs]

@jonringer I believe that's a side effect of node package packaging approach: https://github.com/NixOS/nixpkgs/blob/95dfbe2d63/doc/languages-frameworks/node.section.md#L37-L47

[ersinakinci]

@jonringer, what @rvolosatovs said. I also ran this by @adisbladis in the #nixos IRC channel and they confirmed that this is normal and even desirable.

I think there's a broader conversation to be had about plugin/package management policy as the "updates a million things" behavior is the standard workflow for plugins/packages in other Nixpkgs subsystems (e.g., Vim, Ruby). It's definitely surprising for people coming from outside of Nix and I'm not totally sold on it. But in the context of this particular PR, this is actually the blessed path.

[ersinakinci]

Any progress on this?

[jonringer]

Please also change the commit history so that it's not broken if at a particular commit (you reference nodePackages.coc-prettier before it was added)

the history should reflect:

nodePackages.coc-prettier: init
vimPlugins.overrides: add coc-prettier
neovim: use TMPDIR as home during initilizaiton

[jonringer]

I think this change is unrelated, you added a package to the v10 list, but an entry was updated in the v12 list

[jonringer]

shouldn't that cause a change in pkgs/development/node-packages/node-packages-v10.nix, instead it generates a new file, which seems weird to me.

[ersinakinci]

Just as a reminder from November, I agree that this is weird, but apparently regenerating the entire node-packages-v10.nix and updating a ton of NPM packages in the process is the blessed path. I'm basing this off of 1) a conversation I had in the #nixos IRC channel and 2) the documentation.

[felschr]

Any update on this?

[ersinakinci]

Hey all, I got distracted from finishing this up. I'm going to incorporate @jonringer's suggestions and clean up this PR, hopefully we can get this merged soon.

[ersinakinci]

@jonringer, I've cleaned up this PR and incorporated your suggestions from November. Let me know what you think.

[ersinakinci]

Friendly ping 🙂.

If we can merge this, I have a bunch of other coc extensions that I want to merge, as well. I've successfully been using this approach for ~10 extensions on my local machine via overlays.