-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/httpd: extraSubservices cleanup #66492
Conversation
|
ff149c8
to
460d29e
Compare
@vcunat thanks for the clarification. We'll let this stew a few days and then merge unless @tohl says otherwise I guess then. |
i have no use for btmantis anymore so this can be removed
thanks and sorry for the delay
|
@tohl no problem, thanks! |
Better not me. I'm relatively scarce on time, and my involvement with http services has been almost non-existent, so I'll prefer working on other nixpkgs stuff. |
460d29e
to
efbdce2
Compare
@GrahamcOfBorg test php-pcre |
👍 on removing unmaintained cruft! I would like us to consider what we can do about making web services more generic. I have a feeling all Python applications using The same goes for |
@adisbladis one thought I had was that the I'm planning on putting in a PR to migrate the |
Motivation for this change
services.httpd.extraSubservices
is marked as deprecated so removing some of the final remnants of it.@vcunat what did you want to do with the
btmantis
module? Should be pretty straight forward to change it into a full module like I've done withlimesurvey
,mediawiki
,wordpress
, etc... but if I'm going to do that I'd like to make sure there is someone to list as a maintainer (while I'm happy to rewrite the module if desired I'm not offering to be a maintainer 😄). The other option would be to drop it because it isn't being maintained. Please let me know what you'd like.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @