Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subversion: 1.9.10 -> 1.9.12, 1.10.4 -> 1.10.6 #66439

Merged
merged 1 commit into from
Aug 13, 2019
Merged

subversion: 1.9.10 -> 1.9.12, 1.10.4 -> 1.10.6 #66439

merged 1 commit into from
Aug 13, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Aug 10, 2019 •
edited
Loading

Motivation for this change

#59440
Fix for CVE-2018-11782 and CVE-2019-0203, so requires backport.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@aanderse aanderse added the 9.needs: port to stable A PR needs a backport to the stable release. label Aug 10, 2019
@ofborg ofborg bot requested review from edolstra and lovek323 August 10, 2019 13:42
@aanderse aanderse mentioned this pull request Aug 10, 2019
Merged
10 tasks
@aanderse
Copy link
Member Author

@GrahamcOfBorg test subversion

@infinisil infinisil added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Aug 10, 2019
@aanderse
Copy link
Member Author

see #66492 for cleanup of broken subversion test.

@aanderse aanderse requested a review from andir August 11, 2019 22:08
@aanderse
Copy link
Member Author

Merging now as this is holding up #59440, which I'm keen to get merged and tested with plenty of time to spare before 19.09.

@aanderse aanderse merged commit 8746c77 into NixOS:master Aug 13, 2019
@aanderse aanderse deleted the subversion branch August 13, 2019 00:54
@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 20, 2021
@ghost ghost mentioned this pull request Aug 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@lovek323 lovek323 Awaiting requested review from lovek323

@andir andir Awaiting requested review from andir

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aanderse @infinisil @TredwellGit