-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update macOS to 10.12 #56744
Update macOS to 10.12 #56744
Conversation
b6fdd76
to
64933bd
Compare
It adds /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation to get the objc runtime. It should only be needed if you get errors like:
|
558f20c
to
57aa06f
Compare
If you are just missing _NS* symbols you just need |
This is needed for the bootstrap tools to work: https://hydra.nixos.org/build/92534667
Some old stuff is known not to work.
This avoids some issues encountered with qt5 not working libcxx 7. We can remove this at some point when qt5 has addressed all of their issues.
9a0ed89
to
c1f1a0e
Compare
I recognized that you disabled the entire checkPhase for ldc on Darwin. For dmd the commented make line in the checkPhase should work now again with your changes about the filesystem stuff in the linker and should fix #57120 . |
I was able to compile and run some simple D code, but I can work on getting the tests passing as well |
This pull request has been mentioned on Nix community. There might be relevant details there: https://discourse.nixos.org/t/darwin-macos-10-12-stdenv-updates/2862/1 |
@matthewbauer After reading your post I realised that we didn't update |
Yeah that would be a good idea! Also removing the |
Motivation for this change
This is big enough that it probably needs its own jobset. This bumps the SDKs to 10.12, as well as adds symbols only available in 10.12. As a result, this means that Nixpkgs will only work on systems with macOS 10.12+.
Other things done:
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)