Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ccls: use llvmPackages_latest #113154

Merged
merged 1 commit into from
Feb 15, 2021
Merged

ccls: use llvmPackages_latest #113154

merged 1 commit into from
Feb 15, 2021

Conversation

kira-bruneau
Copy link
Contributor

@kira-bruneau kira-bruneau commented Feb 14, 2021 •
edited
Loading

Motivation for this change

ccls should use llvmPackages_latest to always support the latest C/C++ language features.

Also, clang isn't necessary to compile ccls, so we should use the default stdenv.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 @tobim

@kira-bruneau
Copy link
Contributor Author

Result of nixpkgs-review pr 113154 run on x86_64-linux 1

1 package built:
  • ccls

@Mic92
Copy link
Member

Mic92 commented Feb 14, 2021

@SuperSandro2000 can we get a macOS build here?

@kira-bruneau
Copy link
Contributor Author

Result of nixpkgs-review pr 113154 run on x86_64-darwin 1

1 package built:
  • ccls

r-burns
r-burns approved these changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@r-burns r-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 113154 run on x86_64-darwin 1

1 package built:
  • ccls

@Mic92 Mic92 merged commit a0b1045 into NixOS:master Feb 15, 2021
@kira-bruneau kira-bruneau deleted the ccls branch February 4, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@r-burns r-burns r-burns approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kira-bruneau @Mic92 @r-burns