Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/fish: add functions setting #377592

Closed
wants to merge 5,370 commits into from
Closed

nixos/fish: add functions setting #377592

wants to merge 5,370 commits into from

Conversation

Rua
Copy link

@Rua Rua commented Jan 28, 2025

This adds an option programs.fish.functions. The code is taken from home-manager, but would also be useful for nixpkgs' system-wide configuration.

This is my first time contributing to nixpkgs, and still relatively new to Nix stuff. Feedback and guidance would be welcome!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

mweinelt and others added 30 commits January 19, 2025 17:07
@mweinelt @github-actions
python313Packages.webrtc-noise-gain: fix cross builds
aeb4870 
Closes: NixOS#375092
(cherry picked from commit 1faa66a)
@mweinelt
[Backport release-24.11] python313Packages.webrtc-noise-gain: fix cro…
8623be6 
…ss builds (NixOS#375112)
@wolfgangwalther
[Backport release-24.11] nixos/postgresql: fix condition for readwrit…
9a06c33 
…epaths (NixOS#375027)
@networkException @github-actions
ungoogled-chromium: 131.0.6778.264-1 -> 132.0.6834.83-1
f855bea 
https://chromereleases.googleblog.com/2025/01/stable-channel-update-for-desktop_14.html

This update includes 16 security fixes.

CVEs:
CVE-2025-0434 CVE-2025-0435 CVE-2025-0436 CVE-2025-0437 CVE-2025-0438
CVE-2025-0439 CVE-2025-0440 CVE-2025-0441 CVE-2025-0442 CVE-2025-0443
CVE-2025-0446 CVE-2025-0447 CVE-2025-0448

(cherry picked from commit be13955)
@nixpkgs-ci
Merge release-24.11 into staging-next-24.11
f2b7f6b
@nixpkgs-ci
Merge staging-next-24.11 into staging-24.11
9d02e8d
@wolfgangwalther
[Backport release-24.11] python312Packages.netbox-plugin-dns: init at…
ae36049 
… 1.1.7 (NixOS#374622)
@wolfgangwalther
[Backport release-24.11] python312Packages.netbox-topology-views: ini…
8be920a 
…t at 4.1.0 (NixOS#374623)
@wolfgangwalther
[Backport release-24.11] nixos/realmd: init (NixOS#374643)
9e98b83
@wolfgangwalther
[Backport release-24.11] tmuxPlugins.tmux-powerline: init at 3.0.0 (N…
0165b18 
…ixOS#374681)
@symphorien
[Backport release-24.11] paperwork: fix installing translations (NixO…
e6041fe 
…S#375040)
@GaetanLepage
[Backport release-24.11] skeditor: 2.8.1 -> 2.8.3; iconConvtools: exp…
ed48372 
…and to unix platforms (NixOS#375097)
@wolfgangwalther
[Backport release-24.11] redict: 7.3.0 -> 7.3.2 (NixOS#374779)
e58342b
@wolfgangwalther
[Backport release-24.11] valkey: 8.0.1 -> 8.0.2 (NixOS#374778)
c8b93f6
@wolfgangwalther
[Backport release-24.11] forgejo: 9.0.3 -> 10.0.0 (NixOS#374849)
8dab93a
@wolfgangwalther @github-actions
haskellPackages.ghc-datasize: unbreak
0f688f9 
Builds fine.

(cherry picked from commit 482b0de)
@wolfgangwalther
[Backport release-24.11] mastodon: 4.3.2 -> 4.3.3 (NixOS#374783)
08e9df6
@numinit
mattermostLatest: init at 10.3.1
6410d30 
(cherry picked from commit 6572a7a)
@numinit
mattermostLatest: use 10.4.x branch
efe22e4 
(cherry picked from commit 88ef3d9)
@numinit
mattermostLatest: 10.3.1 -> 10.4.1
541c64a 
Add a lockfileOverlay option that lets us make changes to the package
lockfile if it's broken, such as unlocking packages and letting
npm-lockfile-fix handle them if they are mis-locked.

(cherry picked from commit cbd54cc)
@numinit
mattermost: 9.11.6 -> 9.11.7
49eccad 
(cherry picked from commit 3a98e4e)
@numinit
mattermostLatest: track 10.x instead of 10.4.x
f986628 
We get a new 10.x release every month, so just track latest.

(cherry picked from commit 5a5938f)
@numinit
{mattermost,mattermostLatest}: fix string escapes
3b780d3
@r-ryantm @github-actions
phpunit: 11.5.2 -> 11.5.3
adfdc54 
(cherry picked from commit 1432fb3)
@drupol
[Backport release-24.11] phpunit: 11.5.2 -> 11.5.3 (NixOS#375172)
d6bdd21
@drupol
[Backport release-24.11] mattermostLatest: init at 10.4.1; mattermost…
1a04118 
…: 9.11.6 -> 9.11.7 (NixOS#375146)
@fccapria @github-actions
webcord: 4.10.2 -> 4.10.3
4462f59 
(cherry picked from commit ea2ecb7)
@emilylange
[Backport release-24.11] webcord: 4.10.2 -> 4.10.3 (NixOS#375190)
678e130
@NotAShelf @github-actions
webcord: add NotAShelf to maintainers
679bfc2 
(cherry picked from commit daa15f0)
@NotAShelf @github-actions
{webcord, webcord-vencord}: pin electron_33
0808a8d 
(cherry picked from commit baf60dc)
@github-actions github-actions bot added 6.topic: printing 6.topic: rust 6.topic: policy discussion 6.topic: vim 6.topic: xfce The Xfce Desktop Environment 6.topic: hardware 6.topic: nixos-container Imperative and declarative systemd-nspawn containers 6.topic: pantheon The Pantheon desktop environment 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: testing Tooling for automated testing of packages and modules 6.topic: cinnamon Desktop environment 6.topic: module system About "NixOS" module system internals 6.topic: jitsi 6.topic: systemd 6.topic: agda "A dependently typed programming language / interactive theorem prover" 6.topic: java Including JDK, tooling, other languages, other VMs 6.topic: Lumina DE The Lumina Desktop Environment 6.topic: Enlightenment DE The Enlightenment Desktop Environment 6.topic: mate The MATE Desktop Environment 6.topic: flakes The experimental Nix feature 6.topic: lib The Nixpkgs function library 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 6.topic: php 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 6.topic: k3s Kubernates distribution (https://k3s.io/) 6.topic: deepin Desktop environment and its components 6.topic: dotnet Language: .NET 6.topic: nvidia 6.topic: xen-project The Xen Project hypervisor 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions labels Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: agda "A dependently typed programming language / interactive theorem prover" 6.topic: cinnamon Desktop environment 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: deepin Desktop environment and its components 6.topic: dotnet Language: .NET 6.topic: emacs Text editor 6.topic: Enlightenment DE The Enlightenment Desktop Environment 6.topic: flakes The experimental Nix feature 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: hardware 6.topic: haskell 6.topic: java Including JDK, tooling, other languages, other VMs 6.topic: jitsi 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 6.topic: k3s Kubernates distribution (https://k3s.io/) 6.topic: lib The Nixpkgs function library 6.topic: Lumina DE The Lumina Desktop Environment 6.topic: mate The MATE Desktop Environment 6.topic: module system About "NixOS" module system internals 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: nixos-container Imperative and declarative systemd-nspawn containers 6.topic: nvidia 6.topic: pantheon The Pantheon desktop environment 6.topic: php 6.topic: policy discussion 6.topic: printing 6.topic: python 6.topic: qt/kde 6.topic: rust 6.topic: systemd 6.topic: testing Tooling for automated testing of packages and modules 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: vim 6.topic: xen-project The Xen Project hypervisor 6.topic: xfce The Xfce Desktop Environment 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: module (update) This PR changes an existing module in `nixos/`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.