Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.11] mattermostLatest: init at 10.4.1; mattermost: 9.11.6 -> 9.11.7 #375146

Merged
merged 6 commits into from
Jan 19, 2025

Conversation

numinit
Copy link
Contributor

@numinit numinit commented Jan 19, 2025

Manual backport of #373113. Due to update script changes and Mattermost releasing an update every month, this should be backported to facilitate easier automatic backports in the future.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

(cherry picked from commit 6572a7a)
(cherry picked from commit 88ef3d9)
Add a lockfileOverlay option that lets us make changes to the package
lockfile if it's broken, such as unlocking packages and letting
npm-lockfile-fix handle them if they are mis-locked.

(cherry picked from commit cbd54cc)
(cherry picked from commit 3a98e4e)
We get a new 10.x release every month, so just track latest.

(cherry picked from commit 5a5938f)
@numinit
Copy link
Contributor Author

numinit commented Jan 19, 2025

Only commit that's out of line is due to https://github.com/NixOS/nixpkgs/blame/08e9df6c6126655718a197f5f1274d00206d92cb/pkgs/by-name/ma/mattermost/package.nix#L147 which fixed string escaping.

@drupol drupol merged commit 1a04118 into NixOS:release-24.11 Jan 19, 2025
24 of 28 checks passed
@numinit numinit added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Jan 19, 2025
@numinit
Copy link
Contributor Author

numinit commented Jan 19, 2025

Already merged but this fixes up to medium level security issues as well: https://mattermost.com/security-updates/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants