You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces a derivation for building rzls (the Razor Language Server) from the dotnet/razor repository. While the C# plugin for VS Code bundles rzls for use within the editor, this derivation makes it accessible for other editors by building it separately.
Currently, the versioning process is manual due to Microsoft's build practices. There is an open issue in their repo about improving version tags to enable automated updates in the future.
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages
Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
Tested basic functionality of all binary files (usually in ./result/bin/)
duplicate of #371569 but with a slightly newer version @bretek do you have a preference over which one we go with? seems we came up with almost exactly the same thing
duplicate of #371569 but with a slightly newer version @bretek do you have a preference over which one we go with? seems we came up with almost exactly the same thing
@tris203 😄 they do look very similar. I prefer mine because I've removed a lot of the flags and comments that seem to be unnecessary / specific to roslyn-ls. I've also now added an update script and brought my pull request up to 25052.3
duplicate of #371569 but with a slightly newer version @bretek do you have a preference over which one we go with? seems we came up with almost exactly the same thing
@tris203 😄 they do look very similar. I prefer mine because I've removed a lot of the flags and comments that seem to be unnecessary / specific to roslyn-ls. I've also now added an update script and brought my pull request up to 25052.3
i agree, yours is cleaner. especially with the update script @bretek. would you be willing to cherry pick my maintainer commit onto your branch, and me as a maintainer in your derivation?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
the
8.has: maintainer-list (update)
NixOSInfra
added
the
12. first-time contribution
wegank
added
the
12.approvals: 1
This PR introduces a derivation for building rzls (the Razor Language Server) from the dotnet/razor repository. While the C# plugin for VS Code bundles rzls for use within the editor, this derivation makes it accessible for other editors by building it separately.
Currently, the versioning process is manual due to Microsoft's build practices. There is an open issue in their repo about improving version tags to enable automated updates in the future.
Fix #369979
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.