Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gdal: 3.9.3 -> 3.10.0 #355220

Merged
merged 6 commits into from
Dec 1, 2024
Merged

gdal: 3.9.3 -> 3.10.0 #355220

merged 6 commits into from
Dec 1, 2024

Conversation

khaneliman
Copy link
Contributor

@khaneliman khaneliman commented Nov 11, 2024 •
edited
Loading

Things done

Follow up to #354783

https://github.com/OSGeo/gdal/releases/tag/v3.10.0
I see some new optional dependencies reported:

New optional dependencies
[libavif](https://github.com/AOMediaCodec/libavif) for AVIF driver
[libopendrive](https://github.com/DLR-TS/libOpenDRIVE) for XODR driver

Added libavif optional dependency, but don't see libopendrive packaged.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@khaneliman khaneliman marked this pull request as draft November 11, 2024 15:18
@autra
Copy link
Contributor

autra commented Nov 13, 2024

Thanks to have splitted that. I'd vote to wait for ZHF to end indeed, as gdal tends to break other packages even with minor versions (usually it's just some tests, but let's stay on the safe side of things).

@khaneliman khaneliman marked this pull request as ready for review November 24, 2024 02:46
@l0b0 l0b0 removed their request for review November 24, 2024 21:38
@emilazy
Copy link
Member

emilazy commented Nov 28, 2024

@NixOS/geospatial Hi there, rio-tiler’s tests seem to be segfaulting on this branch. We should move on this update soon because the GCC 14 update is going to break these packages, so it’d be great if you could take a look. I’m happy to help in any way I can.

@imincik
Copy link
Contributor

imincik commented Nov 28, 2024 •
edited
Loading

Result of nixpkgs-review pr 355220 run on x86_64-linux 1

10 packages marked as broken and skipped:
  • python311Packages.python-mapnik
  • python311Packages.python-mapnik.dist
  • python311Packages.worldengine
  • python311Packages.worldengine.dist
  • python312Packages.python-mapnik
  • python312Packages.python-mapnik.dist
  • python312Packages.shimmy
  • python312Packages.shimmy.dist
  • python312Packages.worldengine
  • python312Packages.worldengine.dist
6 packages failed to build:
  • apacheHttpdPackages.mod_tile
  • python311Packages.rio-tiler
  • python311Packages.rio-tiler.dist
  • python312Packages.rio-tiler
  • python312Packages.rio-tiler.dist
  • t-rex
157 packages built:
  • cloudcompare
  • entwine
  • gdal (python312Packages.gdal)
  • gdalMinimal
  • gmt
  • gplates
  • grass
  • mapcache
  • mapnik
  • mapproxy
  • mapproxy.dist
  • mapserver
  • merkaartor
  • mysql-workbench
  • octavePackages.mapping
  • openorienteering-mapper
  • paraview
  • pdal
  • perl538Packages.Tirex
  • perl538Packages.Tirex.devdoc
  • perl540Packages.Tirex
  • perl540Packages.Tirex.devdoc
  • postgresql13JitPackages.postgis
  • postgresql13JitPackages.postgis.doc
  • postgresql13Packages.postgis
  • postgresql13Packages.postgis.doc
  • postgresql14JitPackages.postgis
  • postgresql14JitPackages.postgis.doc
  • postgresql14Packages.postgis
  • postgresql14Packages.postgis.doc
  • postgresql15JitPackages.postgis
  • postgresql15JitPackages.postgis.doc
  • postgresql15Packages.postgis
  • postgresql15Packages.postgis.doc
  • postgresql16JitPackages.postgis
  • postgresql16JitPackages.postgis.doc
  • postgresql16Packages.postgis
  • postgresql16Packages.postgis.doc
  • postgresql17JitPackages.postgis
  • postgresql17JitPackages.postgis.doc
  • postgresql17Packages.postgis
  • postgresql17Packages.postgis.doc
  • python311Packages.bsuite
  • python311Packages.bsuite.dist
  • python311Packages.cartopy
  • python311Packages.cartopy.dist
  • python311Packages.django-bootstrap4
  • python311Packages.django-bootstrap4.dist
  • python311Packages.django-bootstrap5
  • python311Packages.django-bootstrap5.dist
  • python311Packages.drf-extra-fields
  • python311Packages.drf-extra-fields.dist
  • python311Packages.fiona
  • python311Packages.fiona.dist
  • python311Packages.folium
  • python311Packages.folium.dist
  • python311Packages.gdal
  • python311Packages.geoarrow-pandas
  • python311Packages.geoarrow-pandas.dist
  • python311Packages.geoarrow-pyarrow
  • python311Packages.geoarrow-pyarrow.dist
  • python311Packages.geodatasets
  • python311Packages.geodatasets.dist
  • python311Packages.geopandas
  • python311Packages.geopandas.dist
  • python311Packages.geoparquet
  • python311Packages.geoparquet.dist
  • python311Packages.inequality
  • python311Packages.inequality.dist
  • python311Packages.libpysal
  • python311Packages.libpysal.dist
  • python311Packages.mapclassify
  • python311Packages.mapclassify.dist
  • python311Packages.momepy
  • python311Packages.momepy.dist
  • python311Packages.morecantile
  • python311Packages.morecantile.dist
  • python311Packages.netbox-documents
  • python311Packages.netbox-documents.dist
  • python311Packages.osmnx
  • python311Packages.osmnx.dist
  • python311Packages.plotnine
  • python311Packages.plotnine.dist
  • python311Packages.pygmt
  • python311Packages.pygmt.dist
  • python311Packages.pyogrio
  • python311Packages.pyogrio.dist
  • python311Packages.rasterio
  • python311Packages.rasterio.dist
  • python311Packages.rioxarray
  • python311Packages.rioxarray.dist
  • python311Packages.shimmy
  • python311Packages.shimmy.dist
  • python311Packages.wktutils
  • python311Packages.wktutils.dist
  • python312Packages.bsuite
  • python312Packages.bsuite.dist
  • python312Packages.cartopy
  • python312Packages.cartopy.dist
  • python312Packages.django-bootstrap4
  • python312Packages.django-bootstrap4.dist
  • python312Packages.django-bootstrap5
  • python312Packages.django-bootstrap5.dist
  • python312Packages.drf-extra-fields
  • python312Packages.drf-extra-fields.dist
  • python312Packages.fiona
  • python312Packages.fiona.dist
  • python312Packages.folium
  • python312Packages.folium.dist
  • python312Packages.geoarrow-pandas
  • python312Packages.geoarrow-pandas.dist
  • python312Packages.geoarrow-pyarrow
  • python312Packages.geoarrow-pyarrow.dist
  • python312Packages.geodatasets
  • python312Packages.geodatasets.dist
  • python312Packages.geopandas
  • python312Packages.geopandas.dist
  • python312Packages.geoparquet
  • python312Packages.geoparquet.dist
  • python312Packages.inequality
  • python312Packages.inequality.dist
  • python312Packages.libpysal
  • python312Packages.libpysal.dist
  • python312Packages.mapclassify
  • python312Packages.mapclassify.dist
  • python312Packages.momepy
  • python312Packages.momepy.dist
  • python312Packages.morecantile
  • python312Packages.morecantile.dist
  • python312Packages.netbox-documents
  • python312Packages.netbox-documents.dist
  • python312Packages.osmnx
  • python312Packages.osmnx.dist
  • python312Packages.plotnine
  • python312Packages.plotnine.dist
  • python312Packages.pygmt
  • python312Packages.pygmt.dist
  • python312Packages.pyogrio
  • python312Packages.pyogrio.dist
  • python312Packages.rasterio
  • python312Packages.rasterio.dist
  • python312Packages.rioxarray
  • python312Packages.rioxarray.dist
  • python312Packages.wktutils
  • python312Packages.wktutils.dist
  • pytrainer
  • pytrainer.dist
  • qgis
  • qgis-ltr
  • qmapshack
  • saga
  • sumo
  • survex
  • therion
  • tunnelx
  • udig
  • vpv
  • rio-tiler log:
tests/test_io_stac.py ...Fatal Python error: Segmentation fault                                                                                                             │
│                                                                                                                                                                            │
│Thread 0x00007ffecfdff6c0 (most recent call first):                                                                                                                         │
│  File "/nix/store/361mh11gcg987p53zs7cmz89wj6xihyr-python3.11-rasterio-1.4.2/lib/python3.11/site-packages/rasterio/dtypes.py", line 112 in in_dtype_range                  │
│  File "/nix/store/361mh11gcg987p53zs7cmz89wj6xihyr-python3.11-rasterio-1.4.2/lib/python3.11/site-packages/rasterio/__init__.py", line 355 in open                          │
│  File "/nix/store/361mh11gcg987p53zs7cmz89wj6xihyr-python3.11-rasterio-1.4.2/lib/python3.11/site-packages/rasterio/env.py", line 463 in wrapper                            │
│  File "/build/source/tests/test_io_stac.py", line 52 in mock_rasterio_open                                                                                                 │
│  File "/build/source/rio_tiler/io/rasterio.py", line 97 in __attrs_post_init__                                                                                             │
│  File "<attrs generated init rio_tiler.io.rasterio.Reader>", line 14 in __init__                                                                                           │
│  File "/build/source/rio_tiler/io/base.py", line 690 in _reader                                                                                                            │
│  File "/nix/store/igyzv5c2v672mhmx1ha1i7062y6rggqs-python3-3.11.10/lib/python3.11/concurrent/futures/thread.py", line 58 in run                                            │
│  File "/nix/store/igyzv5c2v672mhmx1ha1i7062y6rggqs-python3-3.11.10/lib/python3.11/concurrent/futures/thread.py", line 83 in _worker                                        │
│  File "/nix/store/igyzv5c2v672mhmx1ha1i7062y6rggqs-python3-3.11.10/lib/python3.11/threading.py", line 982 in run                                                           │
│  File "/nix/store/igyzv5c2v672mhmx1ha1i7062y6rggqs-python3-3.11.10/lib/python3.11/threading.py", line 1045 in _bootstrap_inner                                             │
│  File "/nix/store/igyzv5c2v672mhmx1ha1i7062y6rggqs-python3-3.11.10/lib/python3.11/threading.py", line 1002 in _bootstrap                                                   │
│

@emilazy
Copy link
Member

emilazy commented Nov 28, 2024

Do you think we should just mark rio-tiler broken for now, or is it too important? I’m not sure where to start debugging the segfaulting test.

@imincik
Copy link
Contributor

imincik commented Nov 28, 2024

Do you think we should just mark rio-tiler broken for now, or is it too important? I’m not sure where to start debugging the segfaulting test.

rio-tiler is quite important, but I think we can just submit bug report upstream.

@imincik
Copy link
Contributor

imincik commented Nov 28, 2024

cogeotiff/rio-tiler#769

@ofborg ofborg bot requested a review from l0b0 November 28, 2024 15:23
@khaneliman khaneliman removed the request for review from l0b0 November 28, 2024 16:28
@ofborg ofborg bot requested a review from l0b0 November 28, 2024 17:30
@imincik
Copy link
Contributor

imincik commented Nov 29, 2024 •
edited
Loading

cogeotiff/rio-tiler#769

If we can't provide a fix we should mark rio-tiler as broken to unblock this GDAL update.

@imincik
Copy link
Contributor

imincik commented Dec 1, 2024

Result of nixpkgs-review pr 355220 run on x86_64-linux 1

14 packages marked as broken and skipped:
  • python311Packages.python-mapnik
  • python311Packages.python-mapnik.dist
  • python311Packages.rio-tiler
  • python311Packages.rio-tiler.dist
  • python311Packages.worldengine
  • python311Packages.worldengine.dist
  • python312Packages.python-mapnik
  • python312Packages.python-mapnik.dist
  • python312Packages.rio-tiler
  • python312Packages.rio-tiler.dist
  • python312Packages.shimmy
  • python312Packages.shimmy.dist
  • python312Packages.worldengine
  • python312Packages.worldengine.dist
2 packages failed to build:
  • apacheHttpdPackages.mod_tile
  • t-rex
157 packages built:
  • cloudcompare
  • entwine
  • gdal (python312Packages.gdal)
  • gdalMinimal
  • gmt
  • gplates
  • grass
  • mapcache
  • mapnik
  • mapproxy
  • mapproxy.dist
  • mapserver
  • merkaartor
  • mysql-workbench
  • octavePackages.mapping
  • openorienteering-mapper
  • paraview
  • pdal
  • perl538Packages.Tirex
  • perl538Packages.Tirex.devdoc
  • perl540Packages.Tirex
  • perl540Packages.Tirex.devdoc
  • postgresql13JitPackages.postgis
  • postgresql13JitPackages.postgis.doc
  • postgresql13Packages.postgis
  • postgresql13Packages.postgis.doc
  • postgresql14JitPackages.postgis
  • postgresql14JitPackages.postgis.doc
  • postgresql14Packages.postgis
  • postgresql14Packages.postgis.doc
  • postgresql15JitPackages.postgis
  • postgresql15JitPackages.postgis.doc
  • postgresql15Packages.postgis
  • postgresql15Packages.postgis.doc
  • postgresql16JitPackages.postgis
  • postgresql16JitPackages.postgis.doc
  • postgresql16Packages.postgis
  • postgresql16Packages.postgis.doc
  • postgresql17JitPackages.postgis
  • postgresql17JitPackages.postgis.doc
  • postgresql17Packages.postgis
  • postgresql17Packages.postgis.doc
  • python311Packages.bsuite
  • python311Packages.bsuite.dist
  • python311Packages.cartopy
  • python311Packages.cartopy.dist
  • python311Packages.django-bootstrap4
  • python311Packages.django-bootstrap4.dist
  • python311Packages.django-bootstrap5
  • python311Packages.django-bootstrap5.dist
  • python311Packages.drf-extra-fields
  • python311Packages.drf-extra-fields.dist
  • python311Packages.fiona
  • python311Packages.fiona.dist
  • python311Packages.folium
  • python311Packages.folium.dist
  • python311Packages.gdal
  • python311Packages.geoarrow-pandas
  • python311Packages.geoarrow-pandas.dist
  • python311Packages.geoarrow-pyarrow
  • python311Packages.geoarrow-pyarrow.dist
  • python311Packages.geodatasets
  • python311Packages.geodatasets.dist
  • python311Packages.geopandas
  • python311Packages.geopandas.dist
  • python311Packages.geoparquet
  • python311Packages.geoparquet.dist
  • python311Packages.inequality
  • python311Packages.inequality.dist
  • python311Packages.libpysal
  • python311Packages.libpysal.dist
  • python311Packages.mapclassify
  • python311Packages.mapclassify.dist
  • python311Packages.momepy
  • python311Packages.momepy.dist
  • python311Packages.morecantile
  • python311Packages.morecantile.dist
  • python311Packages.netbox-documents
  • python311Packages.netbox-documents.dist
  • python311Packages.osmnx
  • python311Packages.osmnx.dist
  • python311Packages.plotnine
  • python311Packages.plotnine.dist
  • python311Packages.pygmt
  • python311Packages.pygmt.dist
  • python311Packages.pyogrio
  • python311Packages.pyogrio.dist
  • python311Packages.rasterio
  • python311Packages.rasterio.dist
  • python311Packages.rioxarray
  • python311Packages.rioxarray.dist
  • python311Packages.shimmy
  • python311Packages.shimmy.dist
  • python311Packages.wktutils
  • python311Packages.wktutils.dist
  • python312Packages.bsuite
  • python312Packages.bsuite.dist
  • python312Packages.cartopy
  • python312Packages.cartopy.dist
  • python312Packages.django-bootstrap4
  • python312Packages.django-bootstrap4.dist
  • python312Packages.django-bootstrap5
  • python312Packages.django-bootstrap5.dist
  • python312Packages.drf-extra-fields
  • python312Packages.drf-extra-fields.dist
  • python312Packages.fiona
  • python312Packages.fiona.dist
  • python312Packages.folium
  • python312Packages.folium.dist
  • python312Packages.geoarrow-pandas
  • python312Packages.geoarrow-pandas.dist
  • python312Packages.geoarrow-pyarrow
  • python312Packages.geoarrow-pyarrow.dist
  • python312Packages.geodatasets
  • python312Packages.geodatasets.dist
  • python312Packages.geopandas
  • python312Packages.geopandas.dist
  • python312Packages.geoparquet
  • python312Packages.geoparquet.dist
  • python312Packages.inequality
  • python312Packages.inequality.dist
  • python312Packages.libpysal
  • python312Packages.libpysal.dist
  • python312Packages.mapclassify
  • python312Packages.mapclassify.dist
  • python312Packages.momepy
  • python312Packages.momepy.dist
  • python312Packages.morecantile
  • python312Packages.morecantile.dist
  • python312Packages.netbox-documents
  • python312Packages.netbox-documents.dist
  • python312Packages.osmnx
  • python312Packages.osmnx.dist
  • python312Packages.plotnine
  • python312Packages.plotnine.dist
  • python312Packages.pygmt
  • python312Packages.pygmt.dist
  • python312Packages.pyogrio
  • python312Packages.pyogrio.dist
  • python312Packages.rasterio
  • python312Packages.rasterio.dist
  • python312Packages.rioxarray
  • python312Packages.rioxarray.dist
  • python312Packages.wktutils
  • python312Packages.wktutils.dist
  • pytrainer
  • pytrainer.dist
  • qgis
  • qgis-ltr
  • qmapshack
  • saga
  • sumo
  • survex
  • therion
  • tunnelx
  • udig
  • vpv

imincik
imincik approved these changes Dec 1, 2024
View reviewed changes
Copy link
Contributor

@imincik imincik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you very much @khaneliman !

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 1, 2024
@ofborg ofborg bot requested a review from imincik December 1, 2024 13:04
@khaneliman khaneliman merged commit eb57850 into NixOS:master Dec 1, 2024
33 of 34 checks passed
@khaneliman khaneliman deleted the gdal-update branch December 1, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcWeber MarcWeber Awaiting requested review from MarcWeber

@willcohen willcohen Awaiting requested review from willcohen

@dotlambda dotlambda Awaiting requested review from dotlambda

@nialov nialov Awaiting requested review from nialov

@autra autra Awaiting requested review from autra

@nh2 nh2 Awaiting requested review from nh2

@sikmir sikmir Awaiting requested review from sikmir

@l0b0 l0b0 Awaiting requested review from l0b0

@imincik imincik Awaiting requested review from imincik

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@khaneliman @autra @emilazy @imincik @wegank