gdal: disable flaky tests; fix darwin #354783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaneliman
added
the
0.kind: ZHF Fixes
khaneliman
force-pushed
the
gdal
branch
2 times, most recently
from
3e87f08 to
59f2470
Compare
|
tobim
reviewed
Nov 10, 2024
| # failing for unknown reason | ||
| # https://github.com/OSGeo/gdal/pull/10806#issuecomment-2362054085 | ||
| "test_ogr_gmlas_billion_laugh" | ||
| ] |
There was a problem hiding this comment.
This would be an opportunity to disable a few flaky tests that were collected in #327323.
Suggested change
| ] | |
| # Flaky on hydra, collected in https://github.com/NixOS/nixpkgs/pull/327323. | |
| "test_ogr_gmlas_huge_processing_time" | |
| "test_ogr_gpkg_background_rtree_build" | |
| "test_vsiaz_fake_write" | |
| "test_vsioss_6" | |
| ] |
There was a problem hiding this comment.
Looking at how they mark them upstream, wondering if we could set env.CI=true or something to make sure we skip anything they flag as flaky to lower maintenance burden.
There was a problem hiding this comment.
Probably a good idea, but we should check if our list contains anything that is not marked as flaky upstream. We could also ask if they'd consider disabling these tests by default instead.
There was a problem hiding this comment.
Setting CI variable is a good idea even though it currently disables only few tests
|
@khaneliman , thank you very much for your PR. It looks good to me, but I'm not sure if we can bump GDAL version at this stage of release. |
|
Result of 6 packages marked as broken and skipped:
32 packages failed to build:
133 packages built:
|
If you're worried about bumping the version, I could pull that part out and just disable the failing tests for this release. I didn't think the minor version bump would be blocking, though. (But, I'm not familiar with their versioning semantics) |
khaneliman
changed the title
|
|
Split off the version bump to a separate PR if we don't want to merge the bump. So we can just disable tests causing issues before release if maintainers don't feel comfortable bumping the package now. |
|
Bad bot |
Can you relaunch nixpkgs-review? I wouldn't be surprised if most packages are passing now. |
Were fixed in previous versions.
Disabling a few tests that have been reported by various users and upstream to be inconsistent to avoid transient failures and triggering rebuilds.
|
|
Any objections to merging this? |
|
|
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
ZHF: #352882
https://hydra.nixos.org/build/277361377/nixlog/1
Closes #327323
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.