Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.05] ytmdesktop: init at 2.0.6 #353886

Merged
merged 5 commits into from
Nov 7, 2024
Merged

[24.05] ytmdesktop: init at 2.0.6 #353886

merged 5 commits into from
Nov 7, 2024

Conversation

teutat3s
Copy link
Member

@teutat3s teutat3s commented Nov 5, 2024 •
edited
Loading

Things done

Depends on: #352693 (which got merged).

Manual backports of

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@teutat3s teutat3s mentioned this pull request Nov 5, 2024
Merged
21 tasks
@teutat3s teutat3s requested a review from cjshearer November 5, 2024 18:54
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 5, 2024
@teutat3s
Copy link
Member Author

teutat3s commented Nov 6, 2024

@ofborg eval

@cjshearer
Copy link
Member

@ofborg eval

I guess we'll also need to cherry-pick/backport 7fa3c4c

@cjshearer @teutat3s
maintainers: add cjshearer
6d91e36 
(cherry picked from commit 7fa3c4c)
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Nov 7, 2024
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Nov 7, 2024
@ofborg ofborg bot requested a review from cjshearer November 7, 2024 08:41
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 7, 2024
@teutat3s
Copy link
Member Author

teutat3s commented Nov 7, 2024

@ofborg build ytmdesktop

@teutat3s
Copy link
Member Author

teutat3s commented Nov 7, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 353886

x86_64-linux

✅ 1 package built:
  • ytmdesktop

@wegank wegank added the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package label Nov 7, 2024
@r-vdp r-vdp merged commit 4b84260 into NixOS:release-24.05 Nov 7, 2024
39 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjshearer cjshearer cjshearer approved these changes

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@teutat3s @cjshearer @r-vdp @wegank @ninelore