ytmdesktop: init at 2.0.5 #317309
Merged
ytmdesktop: init at 2.0.5 #317309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjshearer
force-pushed
the
ytmdesktop_init_at_2.0.5
branch
2 times, most recently
from
f10b4bc to
4f17302
Compare
cjshearer
added a commit
to cjshearer/nixos-config
that referenced
this pull request
Jun 4, 2024
ofborg
bot
added
8.has: package (new)
cjshearer
force-pushed
the
ytmdesktop_init_at_2.0.5
branch
from
4f17302 to
a249805
Compare
|
Result of 1 package built:
|
|
Tested it locally and looks good to me. Thanks for picking this back up! |
LogicalOverflow
approved these changes
Jun 6, 2024
Alipoodle
reviewed
Jun 6, 2024
wegank
added
the
12.approvals: 1
cjshearer
force-pushed
the
ytmdesktop_init_at_2.0.5
branch
from
a249805 to
d140b2c
Compare
wegank
removed
the
12.approvals: 1
cjshearer
force-pushed
the
ytmdesktop_init_at_2.0.5
branch
from
d140b2c to
73bbac1
Compare
|
Result of 1 package built:
|
ninelore
approved these changes
Jun 9, 2024
wegank
added
the
12.approvals: 2
cjshearer
force-pushed
the
ytmdesktop_init_at_2.0.5
branch
from
73bbac1 to
7d42967
Compare
wegank
removed
the
12.approvals: 2
|
Is there anything else that needs doing for this to be merged? Result of 1 package built:
|
ninelore
approved these changes
Jul 2, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Restores ytmdesktop, a desktop app for Youtube Music. It was previously removed due to missing source. This also expands support to all electron platforms, with the exception of darwin, since I don't have a way to test that and the installation process is slightly different (see my comment above
meta.badPlatformsfor more info).Note that
commandLineArgsare passed from the derivation inputs, enabling a consumer to override it and set a default CLI flag. This is useful for setting values like--password-store="gnome-libsecret", which is sometimes necessary to overcome safeStorage detection outside of predefined desktop environments.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.