Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lomiri.*: Make buildable while waiting for GLib fix #315117

Merged
merged 2 commits into from
May 29, 2024

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented May 27, 2024

Description of changes

#309952 broke lomiri.telephony-service and lomiri.lomiri-indicator-network. The fix is #314043 or a yet-to-be-released GLib bump, but I was told on our staging matrix channel that a staging iteration for 24.05 is not possible in time for the release. Try to disable/exclude the broken bits, see if we can get the DE mostly-functional again.

Still need to check how functional lomiri.lomiri-indicator-network still is. Too broken for the tests, but maybe regular desktop usage is okay.

Edit: Checked on spare hardware, seems to work fine.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

OPNA2608 added 2 commits May 27, 2024 17:08
Needs a GLib change to be fixed, which needs a staging cycle, which I was told won't happen in time anymore.
Luckily it's not a crucial component for the desktop mode.
Needs a GLib change to be fixed, which needs a staging cycle, which I was told won't happen in time anymore.
Seems like only the tests fail though.
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels May 27, 2024
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 27, 2024
@OPNA2608
Copy link
Contributor Author

@ofborg build nixosTests.lomiri

@OPNA2608 OPNA2608 marked this pull request as ready for review May 27, 2024 21:18
@OPNA2608 OPNA2608 merged commit 33ce263 into NixOS:master May 29, 2024
35 checks passed
Copy link
Contributor

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant