Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glib: 2.80.0 -> 2.80.2 #309952

Merged
merged 1 commit into from
May 10, 2024
Merged

glib: 2.80.0 -> 2.80.2 #309952

merged 1 commit into from
May 10, 2024

Conversation

leona-ya
Copy link
Member

@leona-ya leona-ya commented May 7, 2024 •
edited
Loading

Description of changes

https://gitlab.gnome.org/GNOME/glib/-/compare/2.80.0...2.80.2
https://gitlab.gnome.org/GNOME/glib/-/blob/2.80.1/NEWS
https://gitlab.gnome.org/GNOME/glib/-/blob/2.80.2/NEWS

CVE-2024-34397

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@leona-ya leona-ya added the 1.severity: security Issues which raise a security issue, or PRs that fix one label May 7, 2024
jtojnar
jtojnar approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. We will also want to cherry-pick gnome-shell patch but that can go to master https://discourse.gnome.org/t/security-fixes-for-signal-handling-in-gdbus-in-glib/20882

@leona-ya leona-ya requested a review from amaxine May 8, 2024 08:42
@amaxine amaxine removed their request for review May 8, 2024 10:48
@fabianhjr
Copy link
Member

fabianhjr commented May 9, 2024 •
edited
Loading

https://gitlab.gnome.org/GNOME/glib/-/compare/2.80.1...2.80.2

2.80.2 has just released

Overview of changes in GLib 2.80.2, 2024-05-08
==============================================
* Fix a regression with IBus caused by the fix for CVE-2024-34397 (#3353,
  work by Simon McVittie)
* Fix installation directory of the GVariant specification (#3351, work by
  Michael Catanzaro)
* Bugs fixed:
  - #3351 GVariant specification installed in wrong directory (Michael
    Catanzaro)
  - #3353 Fixing CVE-2024-34397 caused regressions for ibus (Simon McVittie)
  - !4052 Backport "gdbusconnection: Fix test signal subscription ordering" to
    glib-2-80
  - !4054 Backport !4049 “Correct installation directory of GVariant
    specification” to glib-2-80
  - !4055 Backport !4053 “gdbusconnection: Allow name owners to have the syntax
    of a well-known name” to glib-2-80

@leona-ya leona-ya changed the title glib: 2.80.0 -> 2.80.1 glib: 2.80.0 -> 2.80.2 May 9, 2024
@ofborg ofborg bot requested a review from jtojnar May 9, 2024 15:25
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels May 10, 2024
@jtojnar jtojnar mentioned this pull request May 10, 2024
Merged
13 tasks
@fabianhjr
Copy link
Member

Been using this on staging-next, is it ok if I merge this into staging today?

@fabianhjr fabianhjr merged commit e37ca96 into NixOS:staging May 10, 2024
29 of 30 checks passed
@vcunat
Copy link
Member

vcunat commented May 21, 2024

This broke libmodulemd build, perhaps surprisingly:

meson.build:78: WARNING: glib >= 2.79.0 documention might not be properly referred from libmodulemd documentation.

meson.build:87:6: ERROR: Problem encountered: Missing GTK documentation for glib: /nix/store/la2ylr97skw8rigwx4bg691lni3hvx04-glib-2.80.2-devdoc/share/doc/glib-2.0/glib/index.html

/cc the staging-next PR #312133. Some RPM-related packages depend on this. (I checked locally that reverting this glib bump would fix the build.)

@vcunat
Copy link
Member

vcunat commented May 21, 2024 •
edited
Loading

The ${glib.devdoc}/share/doc/glib-2.0/glib/index.html path really did disappear with this merge. EDIT: and it's not a mistake of the moveToOutput change.

@vcunat
Copy link
Member

vcunat commented May 21, 2024

Surely it's a consequence of https://gitlab.gnome.org/GNOME/glib/-/commit/548ec9f186d373c4e55528a04d78450f6f2fceef

@vcunat
Copy link
Member

vcunat commented May 21, 2024

Ah, probably this one, let me test:
fedora-modularity/libmodulemd@f333619

vcunat added a commit that referenced this pull request May 21, 2024
@vcunat
libmodulemd: fix build after glib update from PR #309952
dffc52c
@vcunat
Copy link
Member

vcunat commented May 21, 2024

OK, looks good. 🦆

@OPNA2608
Copy link
Contributor

This also broke some packages for the Lomiri DE. Bisected to https://gitlab.gnome.org/GNOME/glib/-/commit/747e3af9987b37847d7d5acbf882d1ee4a6bd91b, https://gitlab.gnome.org/GNOME/glib/-/merge_requests/4073 fixes the issues.

@vcunat
Copy link
Member

vcunat commented May 23, 2024 •
edited
Loading

In 2.80 branch as well: https://gitlab.gnome.org/GNOME/glib/-/commit/2d60dc15390e14c99438179caf8ce159fb51d7a9

EDIT: so it should be in 2.80.3 once it's released, for example.

@OPNA2608
Copy link
Contributor

#314043

@OPNA2608 OPNA2608 mentioned this pull request May 27, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianhjr fabianhjr fabianhjr approved these changes

@dasj19 dasj19 Awaiting requested review from dasj19

@bobby285271 bobby285271 Awaiting requested review from bobby285271

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@hedning hedning Awaiting requested review from hedning

@lovek323 lovek323 Awaiting requested review from lovek323

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@leona-ya @fabianhjr @vcunat @OPNA2608 @jtojnar @wegank