Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.afdko: 3.9.3 -> 3.9.7 #251389

Closed
wants to merge 1 commit into from
Closed

Conversation

h7x4
Copy link
Member

@h7x4 h7x4 commented Aug 25, 2023

Description of changes

Depends on #249201

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@h7x4 h7x4 added 2.status: blocked by pr/issue Another PR or issue is preventing this from being completed 6.topic: python and removed 6.topic: python labels Aug 25, 2023
@sternenseemann
Copy link
Member

Depends on #249201

Then I'd suggest making both changes part of the same PR.

@h7x4
Copy link
Member Author

h7x4 commented Aug 25, 2023

How does one go about doing that? Should I create my own PR, or ask the owner of the other PR to add it to theirs?

@sternenseemann
Copy link
Member

sternenseemann commented Aug 25, 2023

You are the author of the other PR?

@sternenseemann
Copy link
Member

Ah, I thought it was the fonttools PR. I think we probably want to have all three updates in a single-ish PR anyways.

@pbsds
Copy link
Member

pbsds commented Sep 28, 2023

#249201 is merged as of #251878. Current status: https://nixpk.gs/pr-tracker.html?pr=251878

@sternenseemann
Copy link
Member

We can just target staging-next with this, the rebuild seems reasonably small.

@h7x4 h7x4 changed the base branch from master to staging-next September 29, 2023 17:50
@h7x4
Copy link
Member Author

h7x4 commented Sep 29, 2023

@sternenseemann, I changed target to staging-next

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 29, 2023
@NickCao
Copy link
Member

NickCao commented Oct 8, 2023

Superseded by fae629e

@NickCao NickCao closed this Oct 8, 2023
@h7x4 h7x4 deleted the update-afdko branch December 8, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: blocked by pr/issue Another PR or issue is preventing this from being completed 2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants