Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.fonttools: 4.38.0 -> 4.43.1 #251054

Closed
wants to merge 2 commits into from
Closed

python3Packages.fonttools: 4.38.0 -> 4.43.1 #251054

wants to merge 2 commits into from

Conversation

h7x4
Copy link
Member

@h7x4 h7x4 commented Aug 23, 2023

Description of changes

Version bump

Another few tests had to be ignored, as they depend on fs

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@h7x4 h7x4 mentioned this pull request Aug 23, 2023
Closed
12 tasks
@ofborg ofborg bot requested a review from sternenseemann August 23, 2023 23:39
@sternenseemann
Copy link
Member

@ofborg build noto-fonts-emoji

@sternenseemann
Copy link
Member

This appears to break the test suite of afdko.

@h7x4
Copy link
Member Author

h7x4 commented Aug 25, 2023

Yeah, I had a look into it. They seem to have updated a lot of their tests when they last bumped fonttools from 4.39 to 4.42

@h7x4
Copy link
Member Author

h7x4 commented Aug 25, 2023

#251389

@figsoda figsoda added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Aug 25, 2023
@h7x4 h7x4 changed the title python3Packages.fonttools: 4.38.0 -> 4.42.1 python3Packages.fonttools: 4.38.0 -> 4.43.1 Oct 11, 2023
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 11, 2023
@h7x4 h7x4 force-pushed the update-fonttools-438-4421 branch from a57b1ce to b7c56c8 Compare October 12, 2023 22:44
@h7x4
Copy link
Member Author

h7x4 commented Oct 12, 2023

Closing due to #251878

@h7x4 h7x4 closed this Oct 12, 2023
@h7x4 h7x4 deleted the update-fonttools-438-4421 branch November 9, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sternenseemann sternenseemann sternenseemann approved these changes

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@h7x4 @sternenseemann @figsoda