Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alsa-scarlett-gui: fix postInstall indentation, change to not use pname in substituion #246636

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

SebTM
Copy link
Contributor

@SebTM SebTM commented Aug 1, 2023

Description of changes

https://github.com/NixOS/nixpkgs/pull/245260/files#r1280488044

Things done

Fix indentation, change to not use pname in substituion

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@SebTM SebTM force-pushed the fix/alsa-scarlett-gui_post-install branch from ae12d34 to 0aa3278 Compare August 1, 2023 20:29
@SebTM SebTM mentioned this pull request Aug 1, 2023
12 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 1, 2023
@fpletz fpletz merged commit 5888615 into NixOS:master Aug 10, 2023
@SebTM SebTM deleted the fix/alsa-scarlett-gui_post-install branch March 5, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants