Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alsa-scarlett-gui: fixed desktop entry #245260

Merged
merged 5 commits into from
Aug 1, 2023
Merged

alsa-scarlett-gui: fixed desktop entry #245260

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
963dff0
alsa-scarlett-gui: fixed desktop entry
inyourfoss Jul 24, 2023
ef76346
alsa-scarlett-gui: fix for deskop integration
inyourfoss Jul 29, 2023
cc5349f
alsa-scarlet-gui: light refactoring
inyourfoss Jul 29, 2023
982eba6
alsa-scarlett-gui: Change icons path back to relative in desktop entr…
inyourfoss Jul 31, 2023
6966289
alsa-scarlett-gui: light refactoring
inyourfoss Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkgs/applications/audio/alsa-scarlett-gui/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ stdenv.mkDerivation rec {
sourceRoot = "source/src";
nativeBuildInputs = [ pkg-config wrapGAppsHook4 ];
buildInputs = [ gtk4 alsa-lib ];
postInstall = ''
substituteInPlace $out/share/applications/vu.b4.${pname}.desktop \
--replace "Exec=/bin/alsa-scarlett-gui" "Exec=$out/bin/${pname}"
Comment on lines +28 to +29
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intendation is not matching 2 spaces which is written in our contributing guide and also we shouldn't substitute pname wherever possible

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#246636

'';

# causes redefinition of _FORTIFY_SOURCE
hardeningDisable = [ "fortify3" ];
Expand Down