Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsForQt5.mauiPackages: 2.2.1 -> 2.2.2 #219099

Merged
merged 1 commit into from
Apr 23, 2023
Merged

Conversation

dotlambda
Copy link
Member

libsForQt5.mauikit-imagetools fails to build with

/build/mauikit-imagetools-2.2.2/src/code/modules/image2text/src/ocs.cpp: In function 'PIX* qImage2PIX(const QImage&)':
/build/mauikit-imagetools-2.2.2/src/code/modules/image2text/src/ocs.cpp:156:27: error: invalid use of incomplete type 'PIX' {aka 'struct Pix'}
  156 |     l_uint32 *datas = pixs->data;
      |                           ^~
In file included from /nix/store/92jahpf5bhniny3dbq9p0j4k95b70c1r-tesseract-3.05.02/include/tesseract/baseapi.h:34,
                 from /build/mauikit-imagetools-2.2.2/src/code/modules/image2text/src/ocs.cpp:5:
/nix/store/92jahpf5bhniny3dbq9p0j4k95b70c1r-tesseract-3.05.02/include/tesseract/thresholder.h:26:8: note: forward declaration of 'PIX' {aka 'struct Pix'}
   26 | struct Pix;
      |        ^~~
Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

cc @milahu

closes #214179

@dotlambda dotlambda requested review from onny and OPNA2608 March 2, 2023 02:08
@dotlambda dotlambda mentioned this pull request Mar 29, 2023
17 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1-10 labels Apr 14, 2023
@dotlambda dotlambda marked this pull request as ready for review April 23, 2023 21:24
@dotlambda
Copy link
Member Author

Let's merge despite the build failure, I have no idea why it fails for us but not for other distros.

@dotlambda
Copy link
Member Author

Result of nixpkgs-review pr 219099 run on x86_64-linux 1

2 packages failed to build:
  • libsForQt5.mauikit-imagetools
  • libsForQt5.pix
16 packages built:
  • libsForQt5.booth
  • libsForQt5.buho
  • libsForQt5.clip
  • libsForQt5.communicator
  • libsForQt5.index
  • libsForQt5.mauikit
  • libsForQt5.mauikit-accounts
  • libsForQt5.mauikit-calendar
  • libsForQt5.mauikit-filebrowsing
  • libsForQt5.mauikit-texteditor
  • libsForQt5.mauiman
  • libsForQt5.nota
  • libsForQt5.shelf
  • libsForQt5.station
  • libsForQt5.vvave
  • maui-shell

@dotlambda dotlambda merged commit b2d5154 into NixOS:master Apr 23, 2023
@dotlambda dotlambda deleted the mauikit-2.2.2 branch April 23, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant