Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libsForQt5.qtsystems: init at unstable-2019-01-03 #214179

Merged
merged 3 commits into from
Apr 14, 2023
Merged

libsForQt5.qtsystems: init at unstable-2019-01-03 #214179

merged 3 commits into from
Apr 14, 2023

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Feb 2, 2023 •
edited
Loading

Description of changes

Adds the Qt Systems module for Qt5. Will be needed for Lomiri.

Same as #214164, I'll give this some more checking for possible problems once I'm further along with Lomiri.

Looks okay to me now.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
    I tested that they can run, but I don't know what they actually do or how Lomiri uses them, if at all.
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 2, 2023
@OPNA2608 OPNA2608 marked this pull request as draft February 22, 2023 14:04
@dotlambda dotlambda mentioned this pull request Mar 2, 2023
Merged
12 tasks
@OPNA2608 OPNA2608 marked this pull request as ready for review March 3, 2023 13:21
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1902

SuperSandro2000
SuperSandro2000 reviewed Mar 5, 2023
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this not under pkgs/development/libraries/qt-5 ?

pkgs/development/libraries/qtsystems/default.nix Outdated Show resolved Hide resolved
@OPNA2608 OPNA2608 requested a review from ttuegel as a code owner March 5, 2023 19:58
@OPNA2608
Copy link
Contributor Author

OPNA2608 commented Mar 5, 2023

More of the package works like this (substitution of QT_INSTALL_EXAMPLES by one of the Qt hooks seems borked) and libsForQt5.qtfeedback (which similarly doesn't have any releases) is also packaged outside of the Qt5 infrastructure.

Moved into the pkgs/development/libraries/qt-5 infrastructure. Haven't added it to full because some of the other Qt projects also don't seem to be in there, and it doesn't seem important enough to get active development or releases by the Qt company. 🤷

@OPNA2608
libsForQt5.qtsystems: Move to pkgs/development/libraries/qt-5
a7d5904 
Examples & tests dropped because they're harder to get working there, and most other modules don't bother with either.
@OPNA2608 OPNA2608 requested a review from SuperSandro2000 March 5, 2023 20:00
@OPNA2608
libsForQt5.qtsystems: Fix outputs on Darwin, wrap servicefw
dd893bb 
- Neither the tools nor QML plugins are being built on Darwin, so there's nothing to put into the bin output.

- `servicefw browse` needs Qt's sqlite db plugin, so wrap it.
@dotlambda dotlambda mentioned this pull request Mar 29, 2023
Merged
17 tasks
@OPNA2608 OPNA2608 mentioned this pull request Mar 30, 2023
Merged
13 tasks
@OPNA2608 OPNA2608 requested a review from SuperSandro2000 April 3, 2023 18:30
@SuperSandro2000 SuperSandro2000 merged commit bfc75c7 into NixOS:master Apr 14, 2023
@OPNA2608 OPNA2608 mentioned this pull request Oct 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: qt/kde 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OPNA2608 @nixos-discourse @SuperSandro2000