Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use attrsOf in place of loaOf when relevant #20456

Merged
merged 6 commits into from
Feb 19, 2017

Conversation

ericsagnes
Copy link
Contributor

Motivation for this change

loaOf types are problematic. #1800
This is a first pass to fix the options that was wrongly using loaOf in places where attrsOf was expected.

This PR content is fairly conservative, fixing loaOf options for which the attribute name was explicitly used in the implementation section (so that should have not worked fine when a list was used).

Tested by building the manual.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@ericsagnes, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MostAwesomeDude, @bluescreen303 and @chexxor to be potential reviewers.

@domenkozar
Copy link
Member

cc @shlevy as the author of the issue

@joachifm joachifm added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: clean-up labels Jan 1, 2017
@joachifm joachifm merged commit 6dbe55c into NixOS:master Feb 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: clean-up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants