Deprecate loaOf

[shlevy]

types.loaOf only exists for backwards compatibility, and it's kind of a hack and doesn't merge well. We should fix all modules that set a list instead of an attribute set in nixpkgs, then once that's done add a trace message when a config is encountered that uses a list instead of a set.

[Mathnerd314]

Usages:
As type = types.loaOf types.optionSet:

nixos/modules/config/users-groups.nix: users.users, users.groups
nixos/modules/security/pam.nix: security.pam.services
nixos/modules/services/logging/logcheck.nix: ignore, ignoreCron
nixos/modules/services/networking/i2pd.nix: outTunnels, inTunnels
nixos/modules/services/networking/prosody.nix: virtualHosts
nixos/modules/services/networking/tinc.nix: networks
nixos/modules/services/web-servers/zope2.nix: services.zope2.instances
nixos/modules/system/etc/etc.nix: environment.etc
nixos/modules/system/upstart/upstart.nix: jobs
nixos/modules/tasks/filesystems.nix: fileSystems
nixos/modules/tasks/network-interfaces.nix: networking.interfaces
nixos/modules/virtualisation/containers.nix: bindMounts

Others:

nixos/modules/programs/ssh.nix: knownHosts
nixos/modules/services/networking/tinc.nix: hosts

[jagajaga]

Is it still relevant?

[Mathnerd314]

The file systems and users/groups are used in a lot of places in NixOS. It would be a lot of work to change them, but possible. Personally I like having the list / attribute set choice, and now we have loeOf as well, and maybe a loaoeOf is in the future.

I still wonder what @shlevy meant by "doesn't merge well", as that seems to be the key point.

[nbp]

I still wonder what @shlevy meant by "doesn't merge well", as that seems to be the key point.

The problem is that you cannot make list element modular. Using list in NixOS breaks the modularity.

[Ericson2314]

This issue is still valid.

[Ericson2314]

I still wonder what @shlevy meant by "doesn't merge well", as that seems to be the key point.

Uniqueness of names can be nicely enforced by the set too.

[joepie91]

What would replace this type?

[Ericson2314]

attrsOf

[rnhmjoj]

I have made PR #63103 that should safely deprecate loaOf but I need help with testing.
I'm trying to get attention and hopefully speeding this up because maintaining the branch up-to-date is getting complicated as time goes on.

[worldofpeace]

#63103 was merged.